1520394 - Don't invoke js subconfigure as a separate process

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

This will allow deeper knowledge of the subconfigure from the top-level, allowing to get rid of js_option down the road.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1520394 - Send old-configure output through logging.

Rather than letting it go through to sys.stdout/sys.stderr directly.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1520394 - Restore logging to file after running old-configure.

We're going to want to log some more. At the moment, this just adds the
output of subconfigure to top-level config.log, but this will become
more useful down the road.

Depends on D16665

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1520394 - Don't hard code log file name for old-configure.

Instead, use the actual log file name as configured through python
logging. This doesn't make a practical difference now, but will when
subconfigure logs to the toplevel log.

Depends on D16666

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1520394 - Wrap the os and subprocess modules in python configure sandbox.

Because the sandbox has its own environment from which it initializes,
os.environ should reflect that in the sandbox. And the few obvious
things that use os.environ too, i.e. subprocess.*.

Depends on D16667

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1520394 - Don't invoke js subconfigure as a separate process.

Since js configure is also python configure, we can actually create
a ConfigureSandbox directly, with the right environment and arguments.

Depends on D16668

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f611bc50d11c
Send old-configure output through logging. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/596f8d9346ec
Restore logging to file after running old-configure. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/e1f95cea7f0c
Don't hard code log file name for old-configure. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/adc8ba2d499e
Wrap the os and subprocess modules in python configure sandbox. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/ab27c46876dd
Don't invoke js subconfigure as a separate process. r=nalexander

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f611bc50d11c
https://hg.mozilla.org/mozilla-central/rev/596f8d9346ec
https://hg.mozilla.org/mozilla-central/rev/e1f95cea7f0c
https://hg.mozilla.org/mozilla-central/rev/adc8ba2d499e
https://hg.mozilla.org/mozilla-central/rev/ab27c46876dd