Closed
Bug 1520394
Opened 2 years ago
Closed 2 years ago
Don't invoke js subconfigure as a separate process
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(5 files)
This will allow deeper knowledge of the subconfigure from the top-level, allowing to get rid of js_option down the road.
Assignee | ||
Comment 1•2 years ago
|
||
Rather than letting it go through to sys.stdout/sys.stderr directly.
Assignee | ||
Comment 2•2 years ago
|
||
We're going to want to log some more. At the moment, this just adds the output of subconfigure to top-level config.log, but this will become more useful down the road. Depends on D16665
Assignee | ||
Comment 3•2 years ago
|
||
Instead, use the actual log file name as configured through python logging. This doesn't make a practical difference now, but will when subconfigure logs to the toplevel log. Depends on D16666
Assignee | ||
Comment 4•2 years ago
|
||
Because the sandbox has its own environment from which it initializes, os.environ should reflect that in the sandbox. And the few obvious things that use os.environ too, i.e. subprocess.*. Depends on D16667
Assignee | ||
Comment 5•2 years ago
|
||
Since js configure is also python configure, we can actually create a ConfigureSandbox directly, with the right environment and arguments. Depends on D16668
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/f611bc50d11c Send old-configure output through logging. r=nalexander https://hg.mozilla.org/integration/autoland/rev/596f8d9346ec Restore logging to file after running old-configure. r=nalexander https://hg.mozilla.org/integration/autoland/rev/e1f95cea7f0c Don't hard code log file name for old-configure. r=nalexander https://hg.mozilla.org/integration/autoland/rev/adc8ba2d499e Wrap the os and subprocess modules in python configure sandbox. r=nalexander https://hg.mozilla.org/integration/autoland/rev/ab27c46876dd Don't invoke js subconfigure as a separate process. r=nalexander
Comment 7•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f611bc50d11c
https://hg.mozilla.org/mozilla-central/rev/596f8d9346ec
https://hg.mozilla.org/mozilla-central/rev/e1f95cea7f0c
https://hg.mozilla.org/mozilla-central/rev/adc8ba2d499e
https://hg.mozilla.org/mozilla-central/rev/ab27c46876dd
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•