Don't invoke js subconfigure as a separate process

RESOLVED FIXED in Firefox 66

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

4 months ago

This will allow deeper knowledge of the subconfigure from the top-level, allowing to get rid of js_option down the road.

Assignee

Comment 1

4 months ago
Rather than letting it go through to sys.stdout/sys.stderr directly.
Assignee

Comment 2

4 months ago
We're going to want to log some more. At the moment, this just adds the
output of subconfigure to top-level config.log, but this will become
more useful down the road.

Depends on D16665
Assignee

Comment 3

4 months ago
Instead, use the actual log file name as configured through python
logging. This doesn't make a practical difference now, but will when
subconfigure logs to the toplevel log.

Depends on D16666
Assignee

Comment 4

4 months ago
Because the sandbox has its own environment from which it initializes,
os.environ should reflect that in the sandbox. And the few obvious
things that use os.environ too, i.e. subprocess.*.

Depends on D16667
Assignee

Comment 5

4 months ago
Since js configure is also python configure, we can actually create
a ConfigureSandbox directly, with the right environment and arguments.

Depends on D16668
Assignee

Updated

4 months ago
Blocks: 1520395

Comment 6

4 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/f611bc50d11c
Send old-configure output through logging. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/596f8d9346ec
Restore logging to file after running old-configure. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/e1f95cea7f0c
Don't hard code log file name for old-configure. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/adc8ba2d499e
Wrap the os and subprocess modules in python configure sandbox. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/ab27c46876dd
Don't invoke js subconfigure as a separate process. r=nalexander
Assignee

Updated

4 months ago
Depends on: 1520730
Depends on: 1520928
Assignee

Updated

4 months ago
Depends on: 1521284
Assignee

Updated

4 months ago
Depends on: 1523153
You need to log in before you can comment on or make changes to this bug.