1520556 - Bug in checks: deprecatedResultStatus's binding is too generic

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[[:owlish] 🦉 PST]

Currently the deprecatedResultStatus handler is bound to taskGroupResolved exchange by scheduler id. Which means the handler will (and sure does) definitely fire all the time, regardless of whether whether we use Statuses or Checks API.

1. Investigate whether taskCompleted exchange can be used for Statuses API (there was a reason, I think, why taskGroupResolved was chosen... Brian?)

2. Come up with a better binding for taskGroupResolved exchange. This exchange cannot use routes, so probably the primary routing key needs to be examined for possibilities. Another way might be to transfer information about the API used in the exchange message itself, and check for it in the deprecatedResultStatus handler.

3. Current Statuses functionality must not be in any way broken

Comment 1

[Brian Stack [:bstack]]

Is the problem that it fires all of the time or that it reports results all of the time? Firing isn't too bad so long as we don't report results.

I think we chose taskGroupResolved in the first place so that we would only fire the handler when the entire group was done rather than every task within it. You could change to fire on every task resolution I expect if that is the easiest solution. Just would require checking every task in the group before reporting (which I think we later ended up doing anyway?)

Comment 2

[[:owlish] 🦉 PST]

Is the problem that it fires all of the time or that it reports results all of the time? Firing isn't too bad so long as we don't report results.

Yes, the problem is that it reports results all the time.

I expect if that is the easiest solution

I don't know yet. If it's possible to use taskCompleted exchange, it is a solution for sure!

Comment 3

[Brian Stack [:bstack]]

Is it possible to check a task group to see if it is status or checks reporting?

Comment 4

[[:owlish] 🦉 PST]

Maybe! That might be another option, thanks!

Comment 5

[[:owlish] 🦉 PST]

https://github.com/taskcluster/taskcluster/pull/118