1520920 - `mach bootstrap` invokes `mach configure` without a valid mozconfig when targeting Android

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

While working on Bug 1477487, I noticed that mach bootstrap invokes mach configure:

https://searchfox.org/mozilla-central/rev/dac799c9f4e9f5f05c1071cba94f2522aa31f7eb/python/mozbuild/mozbuild/mach_commands.py#2510

For Android targets, that makes no sense: we suggest a mozconfig but we don't create one; that makes mach configure fail immediately (or configure Desktop, which is even weirder).

I have no idea what is intended here, but it's clearly broken for Android targets.

Comment 1

[Nick Alexander :nalexander [he/him]]

Andi: you landed this feature in Bug 1328454. Can you explain what you were trying to achieve, and suggest how we can make this less obnoxious for Android targets?

Comment 2

[Andi [:andi]]

Yes, I've tried a shortcut when implementing that, the patch will fix this by only downloading the artifact without configuring the tree.

Comment 3

[Andi [:andi]]

Attachment: Bug 1520920 - do not 'mach configure' when downloading clang-tidy artifact. r=nalexander

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6bda0108d61
do not 'mach configure' when downloading clang-tidy artifact. r=nalexander

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset d6bda0108d61 (bug 1520920) as requested by the dev

Push that got backed out:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d6bda0108d61e14b30bf8b268884e97b2b073481

Backout:
https://hg.mozilla.org/integration/autoland/rev/2dbc0282899d090127b977912762bf983f56d6c4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ad69518248d
do not 'mach configure' when downloading clang-tidy artifact. r=nalexander

Comment 7

[Andi [:andi]]

This was because a fail in the rebase.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9ad69518248d