Closed Bug 1521000 Opened 5 years ago Closed 5 years ago

Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect
Not set
normal

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(2 files)

This bug is filed to implement the proposal discussed in https://groups.google.com/d/topic/mozilla.dev.platform/lBhFfyh-MJE/discussion.

I've made a try push to make sure this doesn't break any builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8270f6d4f8d365fd20ee2d688fcf4bb31ab2163d

Sylvestre, do you mind checking this if you wanted to autoland the patches after reviewing? Thanks!

Flags: needinfo?(sledru)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9916e7d6e32720362fd18ed03f1acff4884b86df
Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f4630838d46dd81dadb13220a4af0da9e23a619
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
Flags: needinfo?(sledru)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Some conflicts, I fixed the remaining issues in bug 1519636
(and added these two patches in the ignore list)

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.