1521000 - Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[(no longer active)]

This bug is filed to implement the proposal discussed in https://groups.google.com/d/topic/mozilla.dev.platform/lBhFfyh-MJE/discussion.

Comment 1

[(no longer active)]

Attachment: Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format;

ignore-this-changeset

Comment 2

[(no longer active)]

Attachment: Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives;

Depends on D16936

Comment 3

[(no longer active)]

I've made a try push to make sure this doesn't break any builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8270f6d4f8d365fd20ee2d688fcf4bb31ab2163d

Sylvestre, do you mind checking this if you wanted to autoland the patches after reviewing? Thanks!

Comment 4

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9916e7d6e32720362fd18ed03f1acff4884b86df
Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f4630838d46dd81dadb13220a4af0da9e23a619
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9916e7d6e327
https://hg.mozilla.org/mozilla-central/rev/5f4630838d46

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Some conflicts, I fixed the remaining issues in bug 1519636
(and added these two patches in the ignore list)