Closed Bug 1521003 Opened 2 years ago Closed 1 year ago

Code reformatting broke the IPDL unit test build

Categories

(Core :: IPC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jld, Assigned: jld)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The IPDL unit tests (which are, regrettably, not built by default; see discussion in bug 1236717 and bug 1236635) have a file, IPDLUnitTests.template.cpp, with placeholders ${LIKE_THIS} that are substituted with autogenerated code by a Python script. The clang-format pass broke some of them with whitespace changes; for example:

- ${INCLUDES}
+ $ { INCLUDES }

The fix is simple (bracket them in // clang-format off / //clang-format on), and I have a patch.

Blocks: 1513205
No longer blocks: clang-format

Wow, I'm so sorry about this. :-( I wish there was a way we could have found out about this through some failures on try...

(In reply to :Ehsan Akhgari from comment #1)

Wow, I'm so sorry about this. :-( I wish there was a way we could have found out about this through some failures on try...

This code being dead in normal builds is a long-standing problem for IPC (see the bugs linked in comment #0), and it's bit-rotted before as a result; this time was at least fairly straightforward to fix.

This file has text-substitution placeholders that aren't part of normal
C++ syntax; they were broken by auto-inserted whitespace. This patch
restores the original formatting and protects them from further change.

Priority: -- → P1
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d73d61bac7d
Fix the IPDL unit test build after auto-reformatting broke it. r=Ehsan
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.