1521037 - about:preferences dialog close buttons shouldn't be focusable

Status: NEW

(Firefox :: Settings UI, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: about_prefXbtn.png

Note

• The main issue is that the on-hover and on-click effects are of different widths and it looks wierd

Affected versions

• 65.0b12
• 66.0a1

Affected platforms

• Windows 10
• Ubuntu 18.04

Steps to reproduce

1. Access about:preferences#privacy
2. Click on the Saved Logins button;
3. Click inside the Search field;
4. Click and hold on the X button;
5. Holding the button pressed, move the mouse down;
6. Repeat steps 3+5;

Expected result

• effects should have the same size;

Actual result

• the on-click effect width is increased;

Regression range

• First bad: 2018-12-08 16:50:31.162000
• Last good: 2018-12-08 11:30:00.887000
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4c37fbac068d2e4e250d0d90c3c0f4c9129d8b0&tochange=09493e80dbe7c1486eb3c93960cc81f73c8c5356
• Potential regressor: bug 1511394

Additional notes

• 64.0.2 not affected;
• macOS is not affected by this issue;
• attached screenshot with this issue;

Comment 1

[Cristian Fogel [:cfogel]]

Updated summary and STR.

Comment 2

[Dão Gottwald [:dao]]

This button shouldn't be focusable in the first place.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly or even in beta 66 for this.
I'm marking it fix-optional to remove it from weekly triage.

Comment 4

[Cristian Fogel [:cfogel]]

Updating flags as it's still reproducible on current versions.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Cristian - when we mark something wontfix and fix-optional across all versions, it means we don't want to keep marking it affected or keep triaging it. (See Comment 3) We know it hasn't been fixed, but it already has a priority assigned by the triage owner or someone on a related team.
So, please don't mark new versions affected in cases like this, because that means that we see it over and over again in triage. Unless it's a P1 issue that you think it's important to bring back to everyone's attention :)

Comment 6

[Cristian Fogel [:cfogel]]

Roger, thanks for the info!

Comment 7

[Cristian Fogel [:cfogel]]

With macOS 10.15.3, just noticed that this issue reproduces with 76.0 as well.