Closed Bug 1521133 Opened 6 years ago Closed 6 years ago

Disable string tail merging on Windows ASan builds

Categories

(Firefox Build System :: Toolchains, enhancement)

Product:
Firefox Build System
Component:
Toolchains
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: away, Assigned: tjr)

References

Details

Merging string memory triggers violations in ASan's ODR checkers.

We'll need this for bug 1521129 since the issue started happening sometime during LLVM 8.0.0 trunk. But the disable-flag is supported in 7.0.1 (our current version), so we can go ahead and land it independently.

This was already reviewed in bug 1512921, I'm splitting it out.

Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3296484c0237 Disable string tail merging on Windows ASan builds. r=dmajor

https://hg.mozilla.org/mozilla-central/rev/3296484c0237

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → tom
You need to log in before you can comment on or make changes to this bug.