1521170 - Add a rule that prevents calling some Array and String accessor methods without using the return value

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

A few places in our codebase we have code that does the following:

foo.concat(bar);
foo.slice(2);
foo.join(" ");

The three above expressions will leave foo unchanged, however it appears that it will be mutated on each line.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1521170 - Add a rule that prevents calling some Array and String accessor methods without using the return value. r?Standard8,Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9f087ff5a52
Add a rule that prevents calling some Array and String accessor methods without using the return value. r=Standard8

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1521170 - Fix the test message in the use-returnValue.js test. r?Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8b0f4d2fa2c
Fix the test message in the use-returnValue.js test. r=Standard8

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1521170 - The testcases are ExpressionStatements that include MemberExpressions, not just MemberExpressions.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee28acf1382f
The testcases are ExpressionStatements that include MemberExpressions, not just MemberExpressions. r=MattN

Comment 7

[Stefan Hindli [:stefan_hindli]]

Backed out changeset c9f087ff5a52, b8b0f4d2fa2c, ee28acf1382f (Bug 1521170) for X2 / TV failures CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=4e227c741b4bb4ebb15d869a02acb83c1a656a54&selectedJob=223409133

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=4e227c741b4bb4ebb15d869a02acb83c1a656a54&selectedJob=223405726

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=4e227c741b4bb4ebb15d869a02acb83c1a656a54&selectedJob=223414372

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce496fde2edd
Backed out changeset ee28acf1382f for X2 / TV failures CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/02b9e7149911
Backed out changeset b8b0f4d2fa2c for X2 / TV failures CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/9d2e8060ccde
Backed out changeset c9f087ff5a52 for X2 / TV failures CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6094ca026ad
Add a rule that prevents calling some Array and String accessor methods without using the return value. r=Standard8,Gijs

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f6094ca026ad