15215 - fix the setTimeout() hack in charsetDetectorsOverlay.js

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

ftang, according to waterson, you don't need to do this in
charsetDetectorsOverlay.js:

/* this is really hacky, but waterson say it will work */
setTimeout("LoadDetectorsMenu()", 10000);

waterson, can you explain to ftang what he needs to do?

Comment 1

[Chris Waterson]

The "Right Way" (quotes like Dr. Evil) is to use something like:

document.addEventListener('load', MyOnloadHandler, false);

(cc hyatt and joki -- I looked at DOM Level 2 spec and it's different from our
current APIs; obviously, using our current APIs is the only way to make this
work right now.)

This effectively adds an 'onload' handler to your document.

Comment 2

[Frank Tang]

Mark M11.

Comment 3

[joki (gone)]

How is the DOM spec different from our stuff?  We do support multiple way to do
this internally but among them is the DOM compliant one that you gave an
example of.

Comment 4

[Chris Waterson]

Never mind. I was looking at a DOM L2 spec dated March 4, 1999.

Comment 5

[Frank Tang]

I try what waterson put down but it does not work. I may make some stupid mistake there. No time to work on this . Move to M12

Comment 6

[Frank Tang]

reassign Charset Auto Detect menu bugs to cata per bobj/ftang chat.

Comment 7

[bobj]

Out of time for M13, moving to M14.

Comment 8

[Frank Tang]

change OS to ALL

Comment 9

[leger]

Putting on PDT+ radar for beta1.

Comment 10

[bobj]

On 1999-10-15 13:58, ftang said he tried waterson's suggestion, but it did
not work.  But there have been no further comments.  Can someone (ftang or
waterson) offer some enlightenment or details?

Comment 11

[Frank Tang]

cata told me he will change the mecanism for auto detector menu to the mechanism
he used for charset menu, in that case, this code will simply go away when he
change that.

Comment 12

[cata]

Frank's right.

Comment 13

[cata]

Frank is right.

Comment 14

[cata]

Fixed

Comment 15

[Frank Tang]

*** Bug 27950 has been marked as a duplicate of this bug. ***

Comment 16

[Teruko Kobayashi]

I verified this in 2000022108 Win32, Mac, and Linux build.

Comment 17

[BMO Automation]

Attachment: [mozilla/pdf.js] Remove the unused `eventBus` option in `PDFThumbnailViewer` (PR 15215 follow-up) (#16051)