Closed Bug 15215 Opened 21 years ago Closed 20 years ago

fix the setTimeout() hack in charsetDetectorsOverlay.js

Categories

(Core :: Internationalization, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: cata)

References

Details

(Whiteboard: [PDT+] ETA: 14/Feb - Work done, ready for checkin)

ftang, according to waterson, you don't need to do this in
charsetDetectorsOverlay.js:

/* this is really hacky, but waterson say it will work */
setTimeout("LoadDetectorsMenu()", 10000);

waterson, can you explain to ftang what he needs to do?
The "Right Way" (quotes like Dr. Evil) is to use something like:

document.addEventListener('load', MyOnloadHandler, false);

(cc hyatt and joki -- I looked at DOM Level 2 spec and it's different from our
current APIs; obviously, using our current APIs is the only way to make this
work right now.)

This effectively adds an 'onload' handler to your document.
Status: NEW → ASSIGNED
Target Milestone: M11
Mark M11.
How is the DOM spec different from our stuff?  We do support multiple way to do
this internally but among them is the DOM compliant one that you gave an
example of.
Never mind. I was looking at a DOM L2 spec dated March 4, 1999.
I try what waterson put down but it does not work. I may make some stupid mistake there. No time to work on this . Move to M12
Target Milestone: M11 → M12
reassign Charset Auto Detect menu bugs to cata per bobj/ftang chat.
Target Milestone: M13 → M14
Out of time for M13, moving to M14.
change OS to ALL
Hardware: PC → All
Keywords: beta1
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
On 1999-10-15 13:58, ftang said he tried waterson's suggestion, but it did
not work.  But there have been no further comments.  Can someone (ftang or
waterson) offer some enlightenment or details?
cata told me he will change the mecanism for auto detector menu to the mechanism
he used for charset menu, in that case, this code will simply go away when he
change that.
Whiteboard: [PDT+] → [PDT+] ETA: 14/Feb
Frank's right.
Frank is right.
Whiteboard: [PDT+] ETA: 14/Feb → [PDT+] ETA: 14/Feb - Work done, ready for checkin
Fixed
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 27950 has been marked as a duplicate of this bug. ***
I verified this in 2000022108 Win32, Mac, and Linux build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.