1521670 - Use a common naming scheme for the app update browser tests

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Robert Strong (they/them - no direct email)]

When the tests for the About Dialog were created in bug 599233 a naming scheme for the test files was used to make it easier to know what the test actually tests. The existing tests should be renamed so they also use this naming scheme.

About Dialog tests start with
browser_about

Doorhanger tests would start with
browser_doorhanger

Options page tests would start with
browser_options

From bug 599233 comment #6

fc = foreground check
bc = background check
sp = startup processing
check = only the update check was performed (also keeps these tests sorted together)
downloadAuto = an update download was performed automatically (app.update.auto = true)
downloadOptIn = the client chose to download an update (app.update.auto = false)
downloaded = an update was already downloaded automatically (app.update.auto = true)
patch = patch condition tests (also keeps these tests sorted together)

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b46c59463cf414169b9122e1c1dbcde7cc6c787c

Comment 2

[Robert Strong (they/them - no direct email)]

I decided to hold off on the renaming of browser_TelemetryUpdatePing.js and browser_updateAutoPrefUI.js. I'll do these when adding the options page tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d2e3ae5a3b
Use a common naming scheme for the app update browser tests. r=mhowell

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b9d2e3ae5a3b