Create tests for update checking in the Firefox about window

RESOLVED FIXED in Firefox 66

Status

()

defect
RESOLVED FIXED
9 years ago
3 months ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(4 attachments, 8 obsolete attachments)

2.87 KB, patch
mhowell
: review+
Details | Diff | Splinter Review
45.73 KB, patch
Details | Diff | Splinter Review
47.71 KB, patch
rstrong
: review+
Details | Diff | Splinter Review
2.23 KB, patch
rstrong
: review+
Details | Diff | Splinter Review
Spinoff of bug 596813 for tests so bug 596813 can be closed
Flags: in-testsuite?
Rob, do you have an ETA for this bug? If it will take a while I would jump in and update our Mozmill tests as soon as possible to support the new ui.
Not at the moment
Component: General → Application Update
Depends on: 599574
Product: Firefox → Toolkit
It's unlikely that I will get to work on this in the next two weeks, so unassigning myself for now.
Assignee: robert.strong.bugs → nobody
Assignee: nobody → robert.strong.bugs
No longer depends on: 599574

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1c6e21b65899e851d7118f3bc892abc12b04aa6

I am trying to come up with a naming scheme for the tests so it is easier to know what they do and to make it easier to associate them with tests that are the same except for a few details. So far I have

fc = foreground check
bc = background check
sp = startup processing
check = only the update check was performed (also keeps these tests sorted together)
downloadAuto = an update download was performed automatically (app.update.auto = true)
downloadOptIn = the client chose to download an update (app.update.auto = false)
downloaded = an update was already downloaded automatically (app.update.auto = true)
patch = patch condition tests (also keeps these tests sorted together)

Since the chrome tests will be going away soon I just made a copy of the update.sjs file instead of trying to fix the chrome tests to work with the changes needed for the browser-chrome tests.

Attachment #9036511 - Attachment is obsolete: true
Posted patch patch - tests (obsolete) — Splinter Review

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=affaa4fe7ffa9d5526d245f19ae696a2b08238d8

Based on the last push I suspect that a couple of tests fail on debug builds.

I put the file copy and rename in this patch so it is easier to read this change as well as the changes in the next patch.
I copied the test http server handler (update.sjs) to chrome so these changes wouldn't affect the chrome tests since these chrome tests will (hopefully) be going away in the near future.
I moved update.sjs to the browser directory since it will be the only consumer and I renamed it because searching for update.sjs returns unrelated results.

Attachment #9036522 - Attachment is obsolete: true
Attachment #9036524 - Attachment is obsolete: true
Posted patch patch - tests (obsolete) — Splinter Review

The test naming scheme I am using is in comment #6. I plan on changing the existing browser tests to this naming scheme in another bug that I haven't filed yet.

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aa18db4e5a8dc05ec70e1ab1e660c80dd43fe08

Posted patch patch -tests (obsolete) — Splinter Review

Missed an eslint error due to a last minute change

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f9fd5de113d9dd00023a87bf555cbb86804217c

Attachment #9036827 - Attachment is obsolete: true
Attachment #9036510 - Flags: review?(mhowell)
Attachment #9036826 - Flags: review?(mhowell)
Attachment #9036828 - Flags: review?(mhowell)
Attachment #9036510 - Flags: review?(mhowell) → review+
Attachment #9036826 - Flags: review?(mhowell) → review+
Comment on attachment 9036828 [details] [diff] [review]
patch -tests

Review of attachment 9036828 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/tests/browser/app_update.sjs
@@ +70,3 @@
>        if (continueFile.exists()) {
> +        try {
> +          // If the continue file is in use try again the time the timer fires.

typo: "the _next_ time the timer fires."

@@ +170,5 @@
> +    gSlowCheckTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
> +    gSlowCheckTimer.initWithCallback(function(aTimer) {
> +      if (continueFile.exists()) {
> +        try {
> +          // If the continue file is in use try again the time the timer fires.

Same typo.
Attachment #9036828 - Flags: review?(mhowell) → review+

Carrying forward r+

Attachment #9036828 - Attachment is obsolete: true
Attachment #9037028 - Flags: review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1293016267a7
add about dialog app update tests. r=mhowell

Comment on attachment 9036510 [details] [diff] [review]
patch - minor client changes

This is what caused the screenshots test failures so I am not going to land this at this time.

Attachment #9036510 - Attachment is obsolete: true
Flags: needinfo?(robert.strong.bugs)
Attachment #9037050 - Attachment is obsolete: true
Posted patch patch - testsSplinter Review

Changed the browser.ini as follows
[browser_about_bc_downloaded_staged.js]
skip-if = (os == "linux" && verify) || asan

Filed bug 1520672 for the Linux TV failures.

I got an rs from mhowell for disabling the test for TV runs. It appears that during TV runs this test is triggering bug 1388764.

Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc1733154e3d
add about dialog app update tests. r=mhowell
Attachment #9037028 - Attachment is obsolete: true
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee96fa31af70
followup to disable staging tests when running --verify on linux due to this likely causing a crash in TV1 runs. r=me
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.