Closed Bug 1521786 Opened 3 years ago Closed 3 years ago

Keep RefreshDriver ticking before first contentful paint

Categories

(Core :: Layout, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

Keep RefreshDriver ticking before first contentful paint so that we can avoid the latency from re-starting it and can try to paint as soon as possible.
This way there will be pending vsync messages more often and we can for example yield before running slow scripts.

Blocks: 1521931
Blocks: 1521955
Comment on attachment 9038354 [details] [diff] [review]
keep_refreshdriver_running.diff

This kind of opposite to the other patch. We do want to get the first contentful paint asap, so better to keep driver up and running. 4s is "educated guess".
Attachment #9038354 - Flags: review?(afarre)
Comment on attachment 9038354 [details] [diff] [review]
keep_refreshdriver_running.diff

Review of attachment 9038354 [details] [diff] [review]:
-----------------------------------------------------------------

Same thing here, we could easily have prefs for constants here, but I'm ok with not having them.
Attachment #9038354 - Flags: review?(afarre) → review+
Priority: -- → P2
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c77b51f59e0
Keep RefreshDriver ticking before first contentful paint, r=farre
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1524189
Depends on: 1524207
Regressions: 1546098
You need to log in before you can comment on or make changes to this bug.