Open Bug 1521955 Opened 3 years ago Updated 3 years ago

ContentSink should interrupt DOM creation if there is pending vsync

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Priority: -- → P2
Comment on attachment 9039526 [details] [diff] [review]
contentsink_interrupt_3.diff

This is not too beautiful. I think we should simplify when to interrupt contentsink, but this is a minimal patch to
evaluate this approach.
Attachment #9039526 - Flags: review?(hsivonen)
Comment on attachment 9039526 [details] [diff] [review]
contentsink_interrupt_3.diff

Review of attachment 9039526 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a bit worried about doing all the pointer chasing that HighPriorityEventPendingForTopLevelDocumentBeforeContentfulPaint() does on each tree op, but I trust that you've measured that it's better with this patch than without.
Attachment #9039526 - Flags: review?(hsivonen) → review+

I have profiled, and it basically doesn't show up at all. And this case is dealing with after-processing-script-element, which is always slow anyhow.

(In reply to Olli Pettay [:smaug] (massive needinfo queue, ping on IRC on anything urgent) from comment #6)

And this case is dealing with after-processing-script-element, which is always slow anyhow.

Oh, right. My worry about "each tree op" is indeed wrong. Thanks.

Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.