1521881 - Add a back button when not in a top-level view

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

With the manage shortcuts button, it's non-obvious how to get back to the extension list. Same with the details page.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1521881 add "Back" button to shortcut and details views

Comment 2

[Shane Caraveo (:mixedpuppy)]

let me know the results of the discussion on the string.

Comment 3

[Mark Striemer [:mstriemer]]

I discussed this with Emanuela and Meridel and the plan it so add a back chevron to the left of the heading when not on a top-level view (just details and shortcuts I think).

Do you have more info on how this should look, Emanuela?

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1521881 - Back button for about:addons shortcuts and details views r?mixedpuppy

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: weirdalignment.png

This shows some of the places where alignment is strange to me.

Comment 6

[Shane Caraveo (:mixedpuppy)]

The primary issue in my weird image is dealt with in the patch ("manage" heading alignment with back button)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6797d9a2e80
Back button for about:addons shortcuts and details views r=mixedpuppy,flod

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a6797d9a2e80

Comment 9

[CosminB]

Attachment: Bug1521881.gif

I can reproduce this issue on Firefox 66.0a1 (20190125095457) under Win 7 64-bit.

This issue is verified as fixed on Firefox 67.0a1 (20190130001444) and Firefox 66.0b3 (20190128143734) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.