1522230 - Move keyboard shortcuts button into the more options menu

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Mark Striemer [:mstriemer]]

The keyboard shortcuts button doesn't need to be so prominent. It should be moved into the more options (gear, currently) menu instead.

The label should match the heading of the keyboard shortcuts page "Manage Extension Shortcuts", and the old label can be removed.

Comment 1

[Trishul]

Can I work on it?

Comment 2

[Mark Striemer [:mstriemer]]

Yes! We're hoping to get this done this week so time is getting tight but you're more than welcome to.

The more options menu is in extensions.xul [1] and the current button is right above it. It should be the last entry in the menu with a separator above it.

The data-l10n-id will need to change to a new string which should be setup like [2] with a .label and a .accesskey, which can be "K". The label should be "Manage Extension Shortcuts". The old string can be removed.

Once it's in there the code for hiding/showing the button can be removed from extensions.js [3] (there are two places that manage-shortcuts is referenced).

Let me know if you have any questions.

[1] https://searchfox.org/mozilla-central/rev/c035ee7d3a5cd6913e7143e1bce549ffb4a566ff/toolkit/mozapps/extensions/content/extensions.xul#257
[2] https://searchfox.org/mozilla-central/rev/39265dd58298c40bed029617ad408bf806cce761/toolkit/locales/en-US/toolkit/about/aboutAddons.ftl#236
[3] https://searchfox.org/mozilla-central/rev/39265dd58298c40bed029617ad408bf806cce761/toolkit/mozapps/extensions/content/extensions.js#2487

Comment 3

[Trishul]

Awesome!
I am on it.

Comment 4

[Trishul]

Attachment: Bug 1522230 - Move keyboard shortcuts button into the more options menu r=mstriemer

Move keyboard shortcuts button into the more options menu

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/683c4fcf36be
Move keyboard shortcuts button into the more options menu r=mstriemer,aswan,flod

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/683c4fcf36be

Comment 7

[CosminB]

Attachment: Bug1522230.png

I can reproduce this issue on Firefox 66.0a1 (20190125095457) under Win 7 64-bit.

This issue is verified as fixed on Firefox 67.0a1 (20190130001444) and Firefox 66.0b3 (20190128143734) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.