Closed Bug 1521891 Opened 6 years ago Closed 6 years ago

portrait images in list items should leave whitespace on sides to fill out 72x72 box

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: dmosedale, Assigned: Mardak)

References

Details

(Keywords: github-merged)

User Story

QA steps: use dev-test-all and make sure lists all have square images (this depends on what content happens to be running at the time to prove the negative in older versions, but with this bug fixed, they should always be square)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4702
52 bytes, text/x-github-pull-request
Details | Review

Mardak suggests switching from <img> tags to <div> with background images.

Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
Assignee: nobody → edilee
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/1f109abd30f43529a93eb86d6a66a4be88021ebc Bug 1521891 - portrait images in list items should leave whitespace on sides to fill out 72x72 box (#4702)
Blocks: 1522379
Keywords: github-merged
User Story: (updated)

https://hg.mozilla.org/mozilla-central/rev/9fb96d1b0b37

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: