1522015 - Hit MOZ_CRASH(bug: unable to map local clip rect) at libcore/option.rs:1008

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Hit MOZ_CRASH(bug: unable to map local clip rect) at libcore/option.rs:1008

#0 0x7f5f5a38af71 in MOZ_CrashOOL(char const*, int, char const*) src/obj-firefox/dist/include/mozilla/Assertions.h:314:3
#1 0x7f5f5a38af35 in GeckoCrashOOL src/toolkit/xre/nsAppRunner.cpp:4874:3
#2 0x7f5f5bec2fa9 in gkrust_shared::panic_hook::h6ad15ee3f0b5be5f src/toolkit/library/rust/shared/lib.rs:232:8
#3 0x7f5f5bec1fe8 in core::ops::function::Fn::call::h49a8c83693cd3b26 src/libcore/ops/function.rs:78:4
#4 0x7f5f5c81e496 in std::panicking::rust_panic_with_hook::h71214e7ce0f7ac01 /rustc/abe02cefd6cd1916df62ad7dc80161bea50b72e8/src/libstd/panicking.rs:480:16
#5 0x7f5f5c81dfe1 in std::panicking::continue_panic_fmt::ha8b8442f4ea9bcac /rustc/abe02cefd6cd1916df62ad7dc80161bea50b72e8/src/libstd/panicking.rs:390:4
#6 0x7f5f5c81dec5 in rust_begin_unwind /rustc/abe02cefd6cd1916df62ad7dc80161bea50b72e8/src/libstd/panicking.rs:325:4
#7 0x7f5f5c83e09c in core::panicking::panic_fmt::h0c93626b89c38af6 /rustc/abe02cefd6cd1916df62ad7dc80161bea50b72e8/src/libcore/panicking.rs:77:13
#8 0x7f5f5c83e1b2 in core::option::expect_failed::h143b3841283cabae /rustc/abe02cefd6cd1916df62ad7dc80161bea50b72e8/src/libcore/option.rs:1008:4
#9 0x7f5f5c0b813c in _$LT$core..option..Option$LT$T$GT$$GT$::expect::h6697b9a4734fc758 src/libcore/option.rs:322:20
#10 0x7f5f5c0b813c in webrender::picture::TileCache::update_prim_dependencies::h0a3a9263e01bc228 src/gfx/wr/webrender/src/picture.rs:1237
#11 0x7f5f5c0d9794 in webrender::prim_store::PrimitiveStore::update_visibility::h9c9350a199b403e7 src/gfx/wr/webrender/src/prim_store/mod.rs:1941:20
#12 0x7f5f5c0d9441 in webrender::prim_store::PrimitiveStore::update_visibility::h9c9350a199b403e7 src/gfx/wr/webrender/src/prim_store/mod.rs:1851:20
#13 0x7f5f5c0d9441 in webrender::prim_store::PrimitiveStore::update_visibility::h9c9350a199b403e7 src/gfx/wr/webrender/src/prim_store/mod.rs:1851:20
#14 0x7f5f5c0d9441 in webrender::prim_store::PrimitiveStore::update_visibility::h9c9350a199b403e7 src/gfx/wr/webrender/src/prim_store/mod.rs:1851:20
#15 0x7f5f5c0d9441 in webrender::prim_store::PrimitiveStore::update_visibility::h9c9350a199b403e7 src/gfx/wr/webrender/src/prim_store/mod.rs:1851:20
#16 0x7f5f5c1c45c0 in webrender::frame_builder::FrameBuilder::build_layer_screen_rects_and_cull_layers::h77ab5b0fe6d864c3 src/gfx/wr/webrender/src/frame_builder.rs:349:12
#17 0x7f5f5c1c45c0 in webrender::frame_builder::FrameBuilder::build::hb7bba4850fe2b278 src/gfx/wr/webrender/src/frame_builder.rs:481
#18 0x7f5f5c1e2d5f in webrender::render_backend::Document::build_frame::h008dba362a8bedf7 src/gfx/wr/webrender/src/render_backend.rs:510:24
#19 0x7f5f5c1eb73b in webrender::render_backend::RenderBackend::update_document::h0dfceb605e575490 src/gfx/wr/webrender/src/render_backend.rs:1365:40
#20 0x7f5f5c1e96c6 in webrender::render_backend::RenderBackend::prepare_transaction::h3a7a096573ac4e80 src/gfx/wr/webrender/src/render_backend.rs:1241:12
#21 0x7f5f5c1e96c6 in webrender::render_backend::RenderBackend::process_api_msg::h4a2c6b2e0b5add33 src/gfx/wr/webrender/src/render_backend.rs:1169
#22 0x7f5f5c1e3068 in webrender::render_backend::RenderBackend::run::h516627aefb19f593 src/gfx/wr/webrender/src/render_backend.rs:927:20
#23 0x7f5f5c105a41 in webrender::renderer::Renderer::new::_$u7b$$u7b$closure$u7d$$u7d$::h4687c8dbcab4866e src/gfx/wr/webrender/src/renderer.rs:1950:12
#24 0x7f5f5c105a41 in std::sys_common::backtrace::__rust_begin_short_backtrace::h00dfe8c81f40866b src/libstd/sys_common/backtrace.rs:136
#25 0x7f5f5c1d5126 in std::thread::Builder::spawn::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::haa63e69b97230eb0 src/libstd/thread/mod.rs:409:20
#26 0x7f5f5c1d5126 in _$LT$std..panic..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::hcb47e30a8a0e5cbd src/libstd/panic.rs:313
#27 0x7f5f5c1d5126 in std::panicking::try::do_call::h54fcb6e0f58319cd src/libstd/panicking.rs:310
#28 0x7f5f5c823628 in __rust_maybe_catch_panic /rustc/abe02cefd6cd1916df62ad7dc80161bea50b72e8/src/libpanic_abort/lib.rs:39:4

Comment 1

[Nicolas Silva [:nical]]

Looks like there's a few occurrences of this one on crash-stats: https://crash-stats.mozilla.com/signature/?signature=core%3A%3Aoption%3A%3Aexpect_failed%20%7C%20webrender%3A%3Aprim_store%3A%3APrimitiveStore%3A%3Aupdate_visibility&date=%3E%3D2019-01-22T14%3A45%3A45.000Z&date=%3C2019-01-29T14%3A45%3A45.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

Comment 2

[Robin Whittleton]

Hit this after about 20 seconds on https://keithclark.co.uk/labs/css-fps/nojs/ on today’s Nightly (macOS 10.14, 2017 Macbook Pro with Radeon Pro 555 2048 MB and Intel HD Graphics 630 1536 MB).

Comment 3

[Darkspirit]

(In reply to Robin Whittleton from comment #2)

Hit this after about 20 seconds on https://keithclark.co.uk/labs/css-fps/nojs/

Nvidia/Win10: bp-ed6cc31c-8f39-4927-85c0-49dfe0190131
Debian/Macbook: bp-02570b2b-17a6-42e2-bfba-3d3a60190131

This has also visually regressed plus - on Linux - it can be drawn on chrome.

Comment 4

[kait]

I can reproduce the crash reliably with Nvidia/Win10 @ full screen (1080p). The rendering also looks correct at normal aspect-ratios.

What might be more interesting. When I split firefox to the left (so it takes up half of the screen):

1. The crash does not happen (reliably)
2. performance looks noticeably worse(despite theoretically having half the pixels rasterize)
3. I get weird lines all over the place (maybe a clipping issue?)

Images:
https://imgur.com/a/Q4iSpC2

Comment 5

[Dzmitry Malyshau [:kvark]]

Attachment: WR don't panic on non-mappable clip rect

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/141cec39cdb8
WR don't panic on non-mappable clip rect r=gw

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/141cec39cdb8