1522018 - Implement webgl draft ext EXT_float_blend

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P3)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1522018 - Implement webgl draft ext EXT_blend_float.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1522018 - Implement webgl draft ext EXT_float_blend.

Comment 3

[Kelsey Gilbert [:jgilbert]]

This has a chance to break existing content, so let's slip it to 67.
Previously, we didn't validate that float32 rendertargets should not be blendable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d324c3cd63b3
Implement webgl draft ext EXT_float_blend. r=lsalzman,qdot

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d324c3cd63b3

Comment 6

[Florian Scholz (Open Web Docs)]

Extension mentioned on (and marked as draft/experimental)
https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API#Extensions
https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Using_Extensions
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/getSupportedExtensions
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/getExtension

New reference page
https://developer.mozilla.org/en-US/docs/Web/API/EXT_float_blend

Not in release notes, but listed along with other features behind a pref on our "Experimental features" page
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#Canvas_WebGL

Compat data
https://github.com/mdn/browser-compat-data/pull/3569

I noticed that when calling gl.getSupportedExtensions "EXT_float_blend" is not in the list even when the pref "webgl.enable-draft-extensions" is enabled. Maybe this is correct per spec as it is still a draft.

Can you give this a quick review, :jgilbert?

Comment 7

[Kelsey Gilbert [:jgilbert]]

I'm seeing EXT_float_blend with enable-draft-extensions at least on Windows:

< gl.getSupportedExtensions().join('\n')
> "ANGLE_instanced_arrays
  EXT_blend_minmax
  EXT_color_buffer_half_float
  EXT_float_blend

I updated the example to show creation of the webgl2 context, since if someone tries the example with a webgl1 gl, they'll be asking for the wrong extension.

Thanks for writing this!

Comment 8

[Florian Scholz (Open Web Docs)]

I'm seeing EXT_float_blend with enable-draft-extensions at least on Windows

I'm seeing it as well now. Sorry, probably an oversight yesterday. Thanks for checking.

I updated the example to show creation of the webgl2 context, since if someone tries the example with a webgl1 gl, they'll be asking for the wrong extension.

Great catch, thanks!