1535808 - EXT_float_blend restrictions break some content

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

The WebGL WG has decided to implicitly enable this extension.

A TODO from this is to warn when implicitly-enabled extensions are used.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1535808 - Expose and implicitly enable EXT_float_blend.

Chrome team reports that some content is broken being strict about this
validation. Implicitly enable it to preserve functionality.

Comment 2

[Kelsey Gilbert [:jgilbert]]

WebGL PR:
https://github.com/KhronosGroup/WebGL/pull/2830

Comment 3

[Florian Scholz (Open Web Docs)]

We should mention this in the docs and the warning could link to the docs for more information (many warnings have [Learn more] links pointing to MDN which web devs find useful).

Comment 4

[Kelsey Gilbert [:jgilbert]]

PR merged, this ext is now exposable.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/711d5fdae7b2
Expose and implicitly enable EXT_float_blend. r=lsalzman

Comment 6

[Kelsey Gilbert [:jgilbert]]

[Tracking Requested - why for this release]:
Content will break (compared to Chrome) if this fix doesn't make it into 67.

Comment 7

[Pascal Chevrel:pascalc]

Thanks for the heads up. Jeff, once this has landed on central and is verified as fixed, please do an uplift request for our next beta. Would that fix benefit from manual verification from our QA team?

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/711d5fdae7b2

Comment 9

[Kelsey Gilbert [:jgilbert]]

(In reply to Pascal Chevrel:pascalc from comment #7)

Thanks for the heads up. Jeff, once this has landed on central and is verified as fixed, please do an uplift request for our next beta. Would that fix benefit from manual verification from our QA team?

The patch includes tests, so we don't need manual verification.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Looks VERIFIED to me in latest Nightly:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/oes-texture-float.html

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9051470 [details]
Bug 1535808 - Expose and implicitly enable EXT_float_blend.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1522018
• User impact if declined: Some incorrectly-written non-portable content will break as compared to Chrome.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We have automated tests for this, and the patch was written against 67 to begin with, but didn't land before the marge.
• String changes made/needed: none

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9051470 [details]
Bug 1535808 - Expose and implicitly enable EXT_float_blend.

Fix and tests to prevent a WegGL webcompat problem when 67 ships, already fixed and verified on Nightly, uplift approved for 67 beta 4, thanks!

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/13ad686075c4

Comment 14

[Chris Mills [:cmills]]

Note to MDN team:

I've written a release note about this in the Fx67 rel notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/67#Canvas_and_WebGL

As for other docs work, I think we just need to update the BCD for this feature.

Comment 15

[Chris Mills [:cmills]]

I've also removed it from https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features

Comment 16

[Eric Shepherd [:sheppy]]

Updated https://developer.mozilla.org/en-US/docs/Web/API/EXT_float_blend with new details.

BCD was claiming that EXT_float_blend was added in Firefox 67, which is good, but that it was behind a pref, which is not correct, so I've fixed that and submitted BCD PR 4105.