1522053 - Blocked icon and Site Information panel info are lost after moving the tab with blocked media to a new window

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Video of the issue

[Affected versions]:
Nightly 66.0a1 - Build ID: 20190123070847

[Affected platforms]:
Windows 7/10 x64
Mac OS 10.14
Ubuntu 18.04

[Steps to reproduce]:

1. Go to cnn.com/videos - the playback is blocked, blocked icon appears in the URL bar and blocked information is displayed in the Site Information panel
2. Open several other random tabs
3. Right click on the tab with the cnn video
4. Select to Move Tab -> Move to New Window

[Expected]:
The Tab should be moved to a new Window as it was in the original one.

[Actual Results]:
The Blocked icon, as well as the info under Permission in the Site Information panel, are no longer displayed. The video is still blocked but the user has to refresh the page in order for the above items to be displayed again as expected.

Comment 1

[Alastor Wu [:alwu]]

Hi, Dale,
Do you mind take a look for this one?
Thanks.

Comment 2

[Dale Harvey (:daleharvey)]

Good catch, can reproduce, I think this is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1522058 and an issue with us showing the blocked icon based on an event vs based on state, I think we are likely going to want to set a property on the tab that gets cleared on refresh when we see the event, and show the UI based on that state

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Actually I don't think I need to track this as it seems unlikely to block the feature.

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Bug 1522053 - Copy global permissions into new browsers

Comment 5

[Dale Harvey (:daleharvey)]

ok got a working patch for thi, just need to write a test for it, looking around for one thats similiar

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56f40b43c0d4
Copy global permissions into new browsers r=johannh

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/56f40b43c0d4

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 9046862 [details]
Bug 1522053 - Copy global permissions into new browsers

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: Confusing display of autoplay icon (at the wrong time)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch with automated tests
• String changes made/needed:

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9046862 [details]
Bug 1522053 - Copy global permissions into new browsers

Fix for autoplay icon display bug, OK for beta 13 uplift.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/02370e541eb9

Comment 11

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Nightly 67.0a1 (2019-03-04) (64-bit) and on Beta 66.0b13 on Windows 7/10 x64, Ubuntu 16.04 and Mac OS 10.13.
Thanks for the fix Dale!