1522082 - Update memory.fill encoding

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

The current spec requires an unconditional target memory index to follow the opcode bytes, and allows for now flags. Otherwise there is no functional change.

Spec: https://github.com/WebAssembly/bulk-memory-operations/blob/master/proposals/bulk-memory-operations/Overview.md#instruction-encoding

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1522082-memory-fill-encoding.patch

Note, sits on top of my patch for bug 1522081.

Comment 2

[Lars T Hansen [:lth]]

Comment on attachment 9038489 [details] [diff] [review]
bug1522082-memory-fill-encoding.patch

Forgot to handle encoding in text-to-binary.

Comment 3

[Lars T Hansen [:lth]]

Attachment: bug1522082-memory-fill-encoding-v2.patch

Comment 4

[Julian Seward [:jseward]]

Comment on attachment 9038493 [details] [diff] [review]
bug1522082-memory-fill-encoding-v2.patch

Review of attachment 9038493 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.  Again, as with bug 1522081, the spec seems inadequate regarding
the type of the "memory:0x00" immediate, but that strikes me as a bug in the
spec, not a bug in this patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38a052003414
make encoding of memory.fill standard-compliant.  r=jseward

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/38a052003414