1522238 - Set frame timestamps in MediaPipeline

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Dan Minor [:dminor]]

Bug 1515205 has a quick fix to set frame timestamps in VideoStreamEncoder::OnFrame. The proper place for this is in VideoConduit.

Comment 1

[Dan Minor [:dminor]]

I think MediaPipeline makes more sense now that I've had a closer look.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1522238 - Set frame timestamp in MediaPipeline::ProcessVideoFrame; r=pehrsons

In the past we relied upon ViEEncoder::OnFrame to set the render time for
frames. With the branch 64 update, this code moved to
VideoStreamEncoder::OnFrame, and only sets the timestamp if it is greater than
the current time. This results in broken rtp timestamp estimates in the rtcp
sender report, which causes problems for Meet and possibly other services
that rewrite rtp timestamps based upon the sender report.

This patch explicitly sets the timestamp in MediaPipeline. This should give us
the same behaviour that we had before the branch update without requiring local
modifications to upstream code. This leaves the rtp timestamp as zero as that
was not being set before.

This also removes an unused overload of the VideoFrameConverted method.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ca3722dde4
Set frame timestamp in MediaPipeline::ProcessVideoFrame; r=pehrsons

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/19ca3722dde4