Closed Bug 1570673 Opened 1 year ago Closed 1 year ago

No black video sent out if track is muted before MediaPipeline is activated

Categories

(Core :: WebRTC: Audio/Video, defect, P2)

68 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 69+ verified
firefox68 --- wontfix
firefox69 + verified
firefox70 + verified

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

There's a second bug here where frames from SameFrameTimer don't get sent due to bug 1522238. Frames broadcast by the timer have the same timestamp as the last frame and get dropped upstream.

This didn't seem to impact my manual test of the original STR, but it impacts the mochitest I wrote.

Regressed by: 1522238
Status: NEW → ASSIGNED
Attachment #9082953 - Attachment description: Bug 1570673 - Update last frame's time on same-frame-ticks. r?dminor → Bug 1570673 - Update last frame's time on same-frame-ticks. r?bwc
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d2a030d452cb
Add mochitest. r=bwc
https://hg.mozilla.org/integration/autoland/rev/91d822ac2647
Add an active state to VideoFrameConverter and propagate it from MediaPipeline. r=bwc
https://hg.mozilla.org/integration/autoland/rev/acd8b80087e0
Update last frame's time on same-frame-ticks. r=bwc

Comment on attachment 9082952 [details]
Bug 1570673 - Add an active state to VideoFrameConverter and propagate it from MediaPipeline. r?bwc

Beta/Release Uplift Approval Request

  • User impact if declined: Chrome and safari (possibly also Edge) will not be able to receive audio from Firefox in video calls in some cases
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Join a room on https://appr.tc with Firefox
    Mute the camera in Firefox
    Join the same room (same URL) with Chrome or Safari
    Mute the microphone in Chrome or Safari
    Expected: you can hear yourself
    With bug: you can only hear yourself after unmuting the camera in Firefox
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Well covered with unittests and mochitests
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: 68 regression that got public attention: https://groups.google.com/d/msg/discuss-webrtc/Gqo2MfnQWkw/XZYGhjHvDQAJ
  • User impact if declined: Chrome and safari (possibly also Edge) will not be able to receive audio from Firefox in video calls in some cases
  • Fix Landed on Version: 70
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Well covered with unittests and mochitests
  • String or UUID changes made by this patch:
Attachment #9082952 - Flags: approval-mozilla-esr68?
Attachment #9082952 - Flags: approval-mozilla-beta?
Attachment #9082951 - Flags: approval-mozilla-beta?
Attachment #9082953 - Flags: approval-mozilla-beta?
Attachment #9082951 - Flags: approval-mozilla-esr68?
Attachment #9082953 - Flags: approval-mozilla-esr68?
QA Whiteboard: [qa-triaged]

Verified fixed on the latest Firefox Nightly (20190808214929) on Windows 10 and Mac OS 10.14.6

Comment on attachment 9082951 [details]
Bug 1570673 - Add mochitest. r?bwc

Fixes a WebRTC interop bug which can cause users of other browsers to not receive audio from Firefox users. Approved for 69.0b13 and 68.1esr.

Attachment #9082951 - Flags: approval-mozilla-esr68?
Attachment #9082951 - Flags: approval-mozilla-esr68+
Attachment #9082951 - Flags: approval-mozilla-beta?
Attachment #9082951 - Flags: approval-mozilla-beta+
Attachment #9082952 - Flags: approval-mozilla-esr68?
Attachment #9082952 - Flags: approval-mozilla-esr68+
Attachment #9082952 - Flags: approval-mozilla-beta?
Attachment #9082952 - Flags: approval-mozilla-beta+
Attachment #9082953 - Flags: approval-mozilla-esr68?
Attachment #9082953 - Flags: approval-mozilla-esr68+
Attachment #9082953 - Flags: approval-mozilla-beta?
Attachment #9082953 - Flags: approval-mozilla-beta+

At least the second patch needs rebasing for ESR68.

Flags: needinfo?(apehrson)

Verified fixed on Windows 10, Mac OS 10.14.6 and Ubuntu 18.04 using Firefox Beta 69.0b13 (20190812173625)

Status: RESOLVED → VERIFIED

Slight collision with bug 1556696. I'll have the 2nd patch up rebased for esr68 in a bit.

Flags: needinfo?(apehrson)

Verified fixed on Windows 10, Mac OS 10.14.6 and Ubuntu 18.04 using Firefox 68.1.0 ESR (20190814031227) downloaded from https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr68

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.