Closed Bug 1522431 Opened 2 years ago Closed 2 years ago

Implement IC support for BigInt

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(1 file)

Currently with ENABLE_BIGINT, there's a test failure in non262/reflect-parse/expression, in that a cache IC runs into an unexpected type. This is because there's no macroassembler support for bigint tests, and no IC support. This patch will fix it.

Patch taken from :terpri's work in https://phabricator.services.mozilla.com/D14826, but omitting Ion parts.

Blocks: 1522436

(In reply to Andy Wingo [:wingo] from comment #0)

Currently with ENABLE_BIGINT, there's a test failure in non262/reflect-parse/expression, in that a cache IC runs into an unexpected type. This is because there's no macroassembler support for bigint tests, and no IC support. This patch will fix it.

Make sure you Try server the ENABLE_BIGINT changes btw because we run tests there with --ion-eager/--baseline-eager/etc flags so it might uncover more stuff.

Thanks for the tip, will do!

Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/475d0d3f9d24
Implement IC support for BigInt r=jandem,terpri

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.