1522431 - Implement IC support for BigInt

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Andy Wingo [:wingo]]

Currently with ENABLE_BIGINT, there's a test failure in non262/reflect-parse/expression, in that a cache IC runs into an unexpected type. This is because there's no macroassembler support for bigint tests, and no IC support. This patch will fix it.

Patch taken from :terpri's work in https://phabricator.services.mozilla.com/D14826, but omitting Ion parts.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Bug 1522431 - Implement IC support for BigInt

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Andy Wingo [:wingo] from comment #0)

Currently with ENABLE_BIGINT, there's a test failure in non262/reflect-parse/expression, in that a cache IC runs into an unexpected type. This is because there's no macroassembler support for bigint tests, and no IC support. This patch will fix it.

Make sure you Try server the ENABLE_BIGINT changes btw because we run tests there with --ion-eager/--baseline-eager/etc flags so it might uncover more stuff.

Comment 3

[Andy Wingo [:wingo]]

Thanks for the tip, will do!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/475d0d3f9d24
Implement IC support for BigInt r=jandem,terpri

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/475d0d3f9d24