1456569 - BigInt TypedArray extensions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Robin Templeton [:terpri]]

Implement BigInt features related to TypedArrays, including:

 - BigInt64Array and BigUint64Array
 - 64-bit DataView methods
 - 64-bit atomic operations

Comment 1

[Robin Templeton [:terpri]]

Attachment: Part 1: TypedArray API changes

Comment 2

[Robin Templeton [:terpri]]

Attachment: Part 2: TypedArrays

Comment 3

[Robin Templeton [:terpri]]

Attachment: Part 3: DataViews

Comment 4

[Robin Templeton [:terpri]]

Attachment: Part 4: Atomics

Comment 5

[Robin Templeton [:terpri]]

Attachment: Part 1: TypedArray API changes

Comment 6

[Robin Templeton [:terpri]]

Attachment: Part 2: TypedArrays

Comment 7

[Robin Templeton [:terpri]]

Attachment: Part 3: DataViews

Comment 8

[Robin Templeton [:terpri]]

Attachment: Part 4: Atomics

Comment 9

[Robin Templeton [:terpri]]

Attachment: bug 1456569 - Implement BigInt64 and BigUint64Array.

Comment 10

[Robin Templeton [:terpri]]

Attachment: Bug 1507484 - Implement JIT support for BigInt

Rough draft of Ion support for BigInt values

Comment 11

[Phabricator Automation]

Comment on attachment 9032069 [details]
Bug 1507484 - Implement JIT support for BigInt

Revision D14826 was moved to bug 1507484. Setting attachment 9032069 [details] to obsolete.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ccad746f5d8
Implement BigInt64 and BigUint64Array. r=wingo,jwalden,sfink

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ac00e863e0
Backed out changeset 6ccad746f5d8 for Linting opt failure in TypedArray.js CLOSED TREE

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out changeset 6ccad746f5d8 (Bug 1456569) for Linting opt failure in TypedArray.js CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=642420401dbe4795fd32d7c3de41d2dad5d733bc&selectedJob=237483600

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237483600&repo=autoland&lineNumber=281

Backout: https://hg.mozilla.org/integration/autoland/rev/68ac00e863e05091280bf23765607af045cba3cc

Comment 16

[Andy Wingo [:wingo]]

Wow, that's irritating! The error was "invalid typeof comparison value", complaining about "bigint". The bug is in the linter; since bigint, there's a new typeof around!

Comment 17

[Andy Wingo [:wingo]]

Apparently a workaround can be adding // eslint-disable-line valid-typeof to the end of the "offending" lines. Or doing like

// eslint-disable valid-typeof
...
// eslint-enable valid-typeof

Comment 18

[Mark Banner (:standard8)]

(In reply to Andy Wingo [:wingo] from comment #17)

Apparently a workaround can be adding // eslint-disable-line valid-typeof to the end of the "offending" lines. Or doing like

// eslint-disable valid-typeof
...
// eslint-enable valid-typeof

You can also use:

// eslint-disable-next-line valid-typeof

(which I find generally nicer overall).

Comment 19

[Robin Templeton [:terpri]]

i updated the typeof expressions; this should be landable now (thanks :wingo and :standard8 for suggesting workarounds)

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fec598b8ec6cc75f702258798bec22b73b7b1adb

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efc786c70693
Implement BigInt64 and BigUint64Array. r=wingo,jwalden,sfink

Comment 21

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/efc786c70693

Comment 22

[Florian Scholz (Open Web Docs)]

For doc pages written/updated, see https://github.com/mdn/sprints/issues/1002#issuecomment-499090849