Closed Bug 1522500 Opened 5 years ago Closed 5 years ago

Intermittent LeakSanitizer | leak at CompileUtf8

Categories

(Testing :: web-platform-tests, defect, P5)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 fixed, firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(1 file)

Bug 1522500 - Add two more generic JS stack frames to the WPT LSan whitelist.
47 bytes, text/x-phabricator-request
Details | Review

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=223730833&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/IWmxr2iKTomrxDYvle5aSQ/runs/0/artifacts/public/logs/live_backing.log

[task 2019-01-24T13:28:19.164Z] 13:28:19 INFO - TEST-START | /webrtc/promises-call.html
[task 2019-01-24T13:28:19.164Z] 13:28:19 INFO - PID 6191 | (ice/INFO) ICE-PEER(PC:1548336494730252 (id=167503724548 url=http://web-platform.test:8000/webrtc/no-media-call.html):default)/CAND-PAIR(tujg): setting pair to state CANCELLED: tujg|IP4:172.17.0.4:43141/UDP|IP4:172.17.0.4:54696/UDP(host(IP4:172.17.0.4:43141/UDP)|candidate:0 1 UDP 2122187007 172.17.0.4 54696 typ host)
[task 2019-01-24T13:28:19.164Z] 13:28:19 INFO - PID 6191 | #15 0x7f131f8945f2 in js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::AutoVector<JSObject*>&) /builds/worker/workspace/build/src/js/src/builtin/Eval.cpp:573:10
[task 2019-01-24T13:28:19.165Z] 13:28:19 INFO - PID 6191 | #16 0x7f131f8940f7 in js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) /builds/worker/workspace/build/src/js/src/builtin/Eval.cpp:526:10

[task 2019-01-24T13:29:35.975Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at CallFromStack, Interpret, Alloc, nsTSubstring
[task 2019-01-24T13:29:35.975Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame CallFromStack matched a expected leak
[task 2019-01-24T13:29:35.975Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::URL_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle
[task 2019-01-24T13:29:35.975Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame EntrySlotOrCreate matched a expected leak
[task 2019-01-24T13:29:35.975Z] 13:29:35 INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CompileUtf8
[task 2019-01-24T13:29:35.977Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at js::frontend::GeneralParser, js::frontend::GeneralParser
[task 2019-01-24T13:29:35.977Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame js::frontend::GeneralParser matched a expected leak
[task 2019-01-24T13:29:35.978Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at AllocateObjectBuffer, js_arena_malloc, js_pod_arena_malloc, maybe_pod_malloc
[task 2019-01-24T13:29:35.978Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame AllocateObjectBuffer matched a expected leak
[task 2019-01-24T13:29:35.978Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at AllocateObjectBuffer, js::NativeObject::growSlots, updateSlotsForSpan, setLastProperty
[task 2019-01-24T13:29:35.978Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame AllocateObjectBuffer matched a expected leak
[task 2019-01-24T13:29:35.979Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_malloc, js_pod_arena_malloc, nsBaseAppShell::Run
[task 2019-01-24T13:29:35.979Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame js_arena_malloc matched a expected leak
[task 2019-01-24T13:29:35.980Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_malloc, js_pod_arena_malloc, maybe_pod_malloc, js::RunScript
[task 2019-01-24T13:29:35.980Z] 13:29:35 INFO - INFO | LeakSanitizer | Frame js_arena_malloc matched a expected leak
[task 2019-01-24T13:29:35.981Z] 13:29:35 INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_malloc, js_pod_arena_malloc, maybe_pod_malloc, pod_malloc

Summary: Perma tier2 LeakSanitizer | leak at CompileUtf8 → Intermittent LeakSanitizer | leak at CompileUtf8

Waldo, any idea what might be causing this leak? Interesting that it always seems to happen during the WebRTC tests.

Blocks: 1523989
Component: WebRTC → JavaScript Engine
Flags: needinfo?(jwalden)
Keywords: memory-leak

These tests intermittently leak a ton of JS stuff, which is whitelisted. I think this new leak is just some additional stack that is showing up in these leaks, either due to compiler inlining changing or code changes. I'll add CompileUtf8 to the top level WPT whitelist.

Assignee: nobody → continuation
Component: JavaScript Engine → web-platform-tests
Flags: needinfo?(jwalden)
Product: Core → Testing
Blocks: 1525556

Intermittent leaks with js_arena_realloc and CompileUtf8 have started
showing up to leaks involving a bunch of JS stuff, so add them to the
top-level LSan WPT white list.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b8f94d83037
Add two more generic JS stack frames to the WPT LSan whitelist. r=jgraham

https://hg.mozilla.org/mozilla-central/rev/6b8f94d83037

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
status-firefox65: --- → unaffected
status-firefox66: --- → affected
status-firefox-esr60: --- → unaffected
Whiteboard: [checkin-needed-beta]

This hasn't shown up on beta, but it certainly won't hurt to uplift it.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: