Figure out what to do with Firefox UI tests relating to the address bar wrt QuantumBar

RESOLVED FIXED in Firefox 67

Status

enhancement
P2
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: standard8, Assigned: dao)

Tracking

(Blocks 1 bug)

Version 3
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Reporter

Description

5 months ago

We are currently rewriting the address bar (bug 1477942). In checking for failures we've identified that some tests in testing/firefox-ui/tests/functional/locationbar are currently failing:

testing/firefox-ui/tests/functional/locationbar/test_escape_autocomplete.py TestEscapeAutocomplete.test_escape_autocomplete | TimeoutException: Timed out after 5.0 seconds
testing/firefox-ui/tests/functional/locationbar/test_suggest_bookmarks.py TestStarInAutocomplete.test_star_in_autocomplete | TimeoutException: Timed out after 5.0 seconds

Should these be re-written as browser mochitests (if they're not already covered - I think they probably are), or do we need to update Marionette?

If we can port to mochitest-browser, I think we should. The only tests actually requiring firerox-ui should be the ones involving a restart of Firefox (or multiple instances of it). I don't think we have anything like that for the Address Bar.

I'm happy to get rid of those if coverage is present or will be present for quantum bar.

Assignee

Comment 3

4 months ago

I too expect browser chrome tests have us covered here. These tests don't seem to do anything noteworthy, let's get rid of them.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

Comment 5

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59fad017d3c5
Remove redundant address bar UI tests. r=whimboo

Comment 6

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.