1522572 - Introduce a target class specific to local tabs

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

For now, the base Target class contains a couple of things specific to local tab.
Like attachTab and tab property.
I think it would be clearer if these specific were all gathered in a dedicated sub class, next to TargetFactory, which is the main place from which we instantiate them.

While doing that, we can also address a couple of followup comment raised during the last review:
https://phabricator.services.mozilla.com/D15831#inline-94338

• follow up: we should consistently use this._tab in the mixin
• follow up: this toString looks weird, assigning a tab object to an id variable.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1522572 - Move local tab specifics out of TargetMixin.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f975d273eabc
Move local tab specifics out of TargetMixin. r=jdescottes,yulia

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f975d273eabc

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f975d273eabc