Closed Bug 1522572 Opened 10 months ago Closed 3 months ago

Introduce a target class specific to local tabs

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(1 file)

For now, the base Target class contains a couple of things specific to local tab.
Like attachTab and tab property.
I think it would be clearer if these specific were all gathered in a dedicated sub class, next to TargetFactory, which is the main place from which we instantiate them.

While doing that, we can also address a couple of followup comment raised during the last review:
https://phabricator.services.mozilla.com/D15831#inline-94338

  • follow up: we should consistently use this._tab in the mixin
  • follow up: this toString looks weird, assigning a tab object to an id variable.
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: P2 → P1
No longer depends on: dt-fission-framework
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f975d273eabc
Move local tab specifics out of TargetMixin. r=jdescottes,yulia
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.