1522596 - Remove nsIIPCSerializableURI

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[(no longer active)]

It has no reason to exist any more (all nsIURI implementations also implement it) and I'm tired of seeing its overhead in profiles.

Comment 1

[(no longer active)]

Attachment: Bug 1522596 - Remove nsIIPCSerializableURI and move its only member to nsIURI;

Comment 2

[Valentin Gosu [:valentin] (he/him)]

A friendly heads up to Jorg K :) Since TB is not multiprocess, this should be easily solved on the C-C side with empty impls.

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. We've just added nsIIPCSerializableURI to our URLs in Dec. 2018:
https://hg.mozilla.org/comm-central/rev/b382906f387f
So by the looks of it we just remove the include and change to the void functions to a "void method".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d815471fff91
Remove nsIIPCSerializableURI and move its only member to nsIURI; r=valentin

Comment 5

[(no longer active)]

(In reply to Jorg K (GMT+1) from comment #3)

Thanks for the heads-up. We've just added nsIIPCSerializableURI to our URLs in Dec. 2018:
https://hg.mozilla.org/comm-central/rev/b382906f387f
So by the looks of it we just remove the include and change to the void functions to a "void method".

Yes, that should be it. In case somewhere you have classes derived from another class which in turn derives from nsIURI, and your doubly-derived class overrides Serialize(), you may also need to manually add an override declaration like I did here for example: https://hg.mozilla.org/integration/autoland/rev/d815471fff91#l4.38.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d815471fff91