Remove nsIIPCSerializableURI

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

Assignee

Description

4 months ago

It has no reason to exist any more (all nsIURI implementations also implement it) and I'm tired of seeing its overhead in profiles.

Priority: -- → P2
Whiteboard: [necko-triaged]

A friendly heads up to Jorg K :) Since TB is not multiprocess, this should be easily solved on the C-C side with empty impls.

Comment 3

4 months ago

Thanks for the heads-up. We've just added nsIIPCSerializableURI to our URLs in Dec. 2018:
https://hg.mozilla.org/comm-central/rev/b382906f387f
So by the looks of it we just remove the include and change to the void functions to a "void method".

Comment 4

4 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d815471fff91
Remove nsIIPCSerializableURI and move its only member to nsIURI; r=valentin
Assignee

Comment 5

4 months ago

(In reply to Jorg K (GMT+1) from comment #3)

Thanks for the heads-up. We've just added nsIIPCSerializableURI to our URLs in Dec. 2018:
https://hg.mozilla.org/comm-central/rev/b382906f387f
So by the looks of it we just remove the include and change to the void functions to a "void method".

Yes, that should be it. In case somewhere you have classes derived from another class which in turn derives from nsIURI, and your doubly-derived class overrides Serialize(), you may also need to manually add an override declaration like I did here for example: https://hg.mozilla.org/integration/autoland/rev/d815471fff91#l4.38.

Updated

4 months ago
Depends on: 1522847

Comment 6

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.