Port Bug 1522596: Remove nsIIPCSerializableURI

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Comment 1

4 months ago
Posted patch 1522847-serialise.patch - WIP (obsolete) — Splinter Review

Something like this. Compile hasn't finished. I'm not sure whether the bit in nsMsgMailNewsUrl.cpp needs the QI.

(Assignee)

Updated

4 months ago
Version: 60 → Trunk
(Assignee)

Comment 2

4 months ago
Posted patch 1522847-serialise.patch (v1) (obsolete) — Splinter Review
Attachment #9039115 - Attachment is obsolete: true
(Assignee)

Comment 3

4 months ago
Posted patch 1522847-serialise.patch (v2) (obsolete) — Splinter Review

First reviewer wins.

I edited the LDAP file on the comm-beta repo, so the hunk was missing. Now it compiles and links.

Attachment #9039122 - Attachment is obsolete: true
Attachment #9039181 - Flags: review?(mkmelin+mozilla)
Attachment #9039181 - Flags: review?(acelists)
Comment on attachment 9039181 [details] [diff] [review]
1522847-serialise.patch (v2)

Review of attachment 9039181 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/addrbook/src/nsAddbookUrl.cpp
@@ +243,5 @@
> +NS_IMETHODIMP_(void)
> +nsAddbookUrl::Serialize(mozilla::ipc::URIParams &aParams)
> +{
> +  return m_baseURL->Serialize(aParams);
> +}

How come these return something when it's NS_IMETHODIMP_(void) ?
(Assignee)

Comment 5

4 months ago

Good question. The "advanced" compiler clang-cl did say a word :-(

Attachment #9039181 - Attachment is obsolete: true
Attachment #9039181 - Flags: review?(mkmelin+mozilla)
Attachment #9039181 - Flags: review?(acelists)
Attachment #9039198 - Flags: review?(mkmelin+mozilla)
Attachment #9039198 - Flags: review?(mkmelin+mozilla) → review+

Comment 6

4 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/bfa78ee4ab64
Port bug 1522596: Remove reference to nsIIPCSerializableURI and implement Serialize() for AB, mailto and LDAP URLs. r=mkmelin

Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
(Assignee)

Updated

4 months ago
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.