1522847 - Port Bug 1522596: Remove nsIIPCSerializableURI

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

Patch coming, I'll import
https://hg.mozilla.org/integration/autoland/rev/d815471fff91

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1522847-serialise.patch - WIP

Something like this. Compile hasn't finished. I'm not sure whether the bit in nsMsgMailNewsUrl.cpp needs the QI.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1522847-serialise.patch (v1)

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1522847-serialise.patch (v2)

First reviewer wins.

I edited the LDAP file on the comm-beta repo, so the hunk was missing. Now it compiles and links.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9039181 [details] [diff] [review]
1522847-serialise.patch (v2)

Review of attachment 9039181 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/addrbook/src/nsAddbookUrl.cpp
@@ +243,5 @@
> +NS_IMETHODIMP_(void)
> +nsAddbookUrl::Serialize(mozilla::ipc::URIParams &aParams)
> +{
> +  return m_baseURL->Serialize(aParams);
> +}

How come these return something when it's NS_IMETHODIMP_(void) ?

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1522847-serialise.patch (v3)

Good question. The "advanced" compiler clang-cl did say a word :-(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bfa78ee4ab64
Port bug 1522596: Remove reference to nsIIPCSerializableURI and implement Serialize() for AB, mailto and LDAP URLs. r=mkmelin