1522757 - Remove addons with no shortcut from extension shortcut page

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Trishul]

Attachment: about:addons

In about:addons, when we go to Manage extensions shortcut I can see list of all addons, even the addons which have no shortcuts.
It will be easier for user to get addons only with shortcuts when he has lots of addons installed.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: no-shortcuts-text.png

Thanks, we had been discussing this but hadn't filed a bug yet.

Instead of including a card for these extensions, they should just be listed at the bottom so the user can tell that there are no shortcuts and they aren't missing it.

The following extensions do not have shortcuts:

Comment 2

[Trishul]

Looks way better without cards, cool.
Can I work on this too?

Comment 3

[Mark Striemer [:mstriemer]]

Absolutely! The mock included uses a comma-separated list but that won't localize very well. It should instead be an unordered list under the message.

Comment 4

[Trishul]

Attachment: Bug 1522757 - Remove addons with no shortcut from extension shortcut page r=mstriemer

Remove addons with no shortcut from extension shortcut page

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8607666f33d8
Remove addons with no shortcut from extension shortcut page r=mstriemer,Gijs,flod

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8607666f33d8

Comment 7

[CosminB]

Attachment: Bug1522757.png

I can reproduce this issue on Firefox 66.0b6(20190207161357) under Win 7 64-bit Mac OS X 10.14.1.

This issue is verified as fixed on Firefox 67.0a1(20190210213844) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.