1522828 - Message API (WebExtension) function to detach and/or delete attachments

Status: REOPENED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

We need an API to detach and/or delete attachments.

It should be possible to do this as a bulk operation.

An additional permission may be necessary.

This API would be necessary for add-ons like "AttachmentExtractor" / "AttachmentExtractor Continued".

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Any interesst in providing the necessary API? Maybe I'm wrong and no additional API is necessary?

Related Bugs:
Bug 92146 (Thunderbird should provide the features itself)
Bug 1578801 (Provide an additional save path attribute)

Comment 2

[Mark Banner (:standard8)]

Bug 1645595 would likely need to be fixed before or as part of this.

Comment 3

[Worcester12345]

See also: 1727543

https://bugzilla.mozilla.org/show_bug.cgi?id=1727543

Comment 4

[John Bieling (:TbSync)]

Attachment: Bug 1522828 - Add messages.detachAttachments() method. r=mkmelin

Comment 5

[John Bieling (:TbSync)]

Attachment: Bug 1522828 - Add messages.deleteAttachments() method. r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ee2aefbbec08
Add messages.deleteAttachments() method. r=mkmelin

Comment 7

[John Bieling (:TbSync)]

We are still working on the detach option.

Comment 8

[Magnus Melin [:mkmelin]]

Looks like you broke comm/mail/components/extensions/test/browser/browser_ext_messages_open_attachment.js

Comment 9

[John Bieling (:TbSync)]

Attachment: Bug 1522828 - Fix broken usage of getUriForMsg() and broken schema definitions. r=mkmelin

Comment 10

[John Bieling (:TbSync)]

Fixed.

Comment 11

[Geoff Lankow (:darktrojan)]

And mail/components/extensions/test/xpcshell/test_ext_messages_attachments.js, not fixed by the new patch.

Comment 12

[Geoff Lankow (:darktrojan)]

And there's an error in the schema tripping up the debug tests. I think you want minItems instead of minimum when it relates to arrays.

Since it's very late where you are I'm going to back this out and you can fix it in the morning.

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da59d14e87f9
Backed out changeset ee2aefbbec08 for multiple test failures.

Comment 14

[John Bieling (:TbSync)]

Try run is looking good now:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=12e2c1e6223cb12766d7527bad9674ede0ea45a3

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b51fb504a659
Add messages.deleteAttachments() method. r=mkmelin
https://hg.mozilla.org/comm-central/rev/0816e8b5b6fb
Fix broken usage of getUriForMsg() and broken schema definitions. r=mkmelin