Open Bug 1522828 Opened 6 years ago Updated 1 month ago

Message API (WebExtension) function to detach and/or delete attachments

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

enhancement

Tracking

(Not tracked)

REOPENED
123 Branch

People

(Reporter: Thunderbird_Mail_DE, Assigned: TbSync)

References

Details

(Keywords: leave-open)

Attachments

(2 files, 1 obsolete file)

We need an API to detach and/or delete attachments.

It should be possible to do this as a bulk operation.

An additional permission may be necessary.

This API would be necessary for add-ons like "AttachmentExtractor" / "AttachmentExtractor Continued".

Any interesst in providing the necessary API? Maybe I'm wrong and no additional API is necessary?

Related Bugs:
Bug 92146 (Thunderbird should provide the features itself)
Bug 1578801 (Provide an additional save path attribute)

Blocks: webext-tb

Bug 1645595 would likely need to be fixed before or as part of this.

Depends on: 1645595
See Also: → 1696777
Severity: normal → S3
Whiteboard: [Prio2023]
Assignee: nobody → john
Status: NEW → ASSIGNED
Attachment #9367438 - Attachment is obsolete: true

Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/ee2aefbbec08
Add messages.deleteAttachments() method. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

We are still working on the detach option.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Looks like you broke comm/mail/components/extensions/test/browser/browser_ext_messages_open_attachment.js

Flags: needinfo?(john)

Fixed.

Flags: needinfo?(john)

And mail/components/extensions/test/xpcshell/test_ext_messages_attachments.js, not fixed by the new patch.

Flags: needinfo?(john)

And there's an error in the schema tripping up the debug tests. I think you want minItems instead of minimum when it relates to arrays.

Since it's very late where you are I'm going to back this out and you can fix it in the morning.

Backout by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/da59d14e87f9
Backed out changeset ee2aefbbec08 for multiple test failures.
Attachment #9371525 - Attachment description: Bug 1522828 - Fix broken usage of getUriForMsg(). r=mkmelin → Bug 1522828 - Fix broken usage of getUriForMsg() and broken schema definitions. r=mkmelin

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b51fb504a659
Add messages.deleteAttachments() method. r=mkmelin
https://hg.mozilla.org/comm-central/rev/0816e8b5b6fb
Fix broken usage of getUriForMsg() and broken schema definitions. r=mkmelin

Target Milestone: --- → 123 Branch
Whiteboard: [Prio2023]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: