Users should be able to delete storage items via Backspace key

RESOLVED FIXED in Firefox 68

Status

enhancement
P2
normal
RESOLVED FIXED
6 months ago
22 days ago

People

(Reporter: davidwalsh, Assigned: miker)

Tracking

({dev-doc-complete})

unspecified
Firefox 68

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The only way to delete a storage item is to right-click and do so via a context menu, which is time-consuming if you want to remove many but not all items.

Allowing a single keyboard button to do so would be incredibly useful.

Posted patch 1522893.patch (obsolete) — Splinter Review

Just hoping for some feedback here, :mratcliffe; I'd love more guidance.

Additionally, it seems as though removing sessionStorage items doesn't work.

Assignee: nobody → dwalsh
Attachment #9039149 - Flags: feedback?(mratcliffe)
Comment on attachment 9039149 [details] [diff] [review]
1522893.patch

Review of attachment 9039149 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks like it should work to me... is it not working?

> Additionally, it seems as though removing sessionStorage items doesn't work.

You mean using the delete key? That surprises me because localStorage and sessionStorage use almost identical code.
Attachment #9039149 - Flags: feedback?(mratcliffe) → feedback+
Priority: -- → P2
Attachment #9039149 - Flags: review?(mratcliffe)
Comment on attachment 9039149 [details] [diff] [review]
1522893.patch

Sorry, because you didn't use Phabricator I didn't know this patch was here. I have created a patch that works just fine but I will assign you for review if that is okay.
Attachment #9039149 - Attachment is obsolete: true
Attachment #9039149 - Flags: review?(mratcliffe)
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9c222097ae1
Allow deletion of storage items via keyboard r=davidwalsh

Backed out changeset b9c222097ae1 (bug 1522893) for devtools failures at devtools/client/storage/test/browser_storage_delete.js

Backout: https://hg.mozilla.org/integration/autoland/rev/3653c185546ba9b9e720cc135a28f87f09ba1ac7

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=234808812&revision=b9c222097ae1e830e0d075677976463df0fd289f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234808812&repo=autoland&lineNumber=11737

task 2019-03-19T16:43:27.376Z] 16:43:27 INFO - TEST-PASS | devtools/client/storage/test/browser_storage_delete.js | Context menu item label contains 'ls1' (maybe truncated) -
[task 2019-03-19T16:43:27.377Z] 16:43:27 INFO - Console message: [JavaScript Error: "TypeError: this.table.selectedRow is undefined" {file: "resource://devtools/client/storage/ui.js" line: 1308}]
[task 2019-03-19T16:43:27.378Z] 16:43:27 INFO - onPopupHidden
[task 2019-03-19T16:43:27.378Z] 16:43:27 INFO - Buffered messages finished
[task 2019-03-19T16:43:27.378Z] 16:43:27 INFO - TEST-UNEXPECTED-FAIL | devtools/client/storage/test/browser_storage_delete.js | Test timed out -
[task 2019-03-19T16:43:27.379Z] 16:43:27 INFO - GECKO(3886) | console.warn: "Error while detaching the thread front: 'detach' request packet to 'server1.conn14.child1/context19' can't be sent as the connection is closed."
[task 2019-03-19T16:43:27.379Z] 16:43:27 INFO - Removing tab.
[task 2019-03-19T16:43:27.380Z] 16:43:27 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-03-19T16:43:27.402Z] 16:43:27 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-03-19T16:43:27.418Z] 16:43:27 INFO - Tab removed and finished closing
[task 2019-03-19T16:43:27.474Z] 16:43:27 INFO - GECKO(3886) | MEMORY STAT | vsize 20974176MB | residentFast 1223MB
[task 2019-03-19T16:43:27.476Z] 16:43:27 INFO - TEST-OK | devtools/client/storage/test/browser_storage_delete.js | took 90543ms
[task 2019-03-19T16:43:27.558Z] 16:43:27 INFO - checking window state
[task 2019-03-19T16:43:27.600Z] 16:43:27 INFO - TEST-START | devtools/client/storage/test/browser_storage_delete_all.js
[task 2019-03-19T16:43:27.798Z] 16:43:27 INFO - GECKO(3886) | added cookies and storage from main page
[task 2019-03-19T16:43:27.935Z] 16:43:27 INFO - GECKO(3886) | added cookies and storage from unsecured iframe
[task 2019-03-19T16:43:27.959Z] 16:43:27 INFO - GECKO(3886) | added cookies and storage from secured iframe
[task 2019-03-19T16:44:57.665Z] 16:44:57 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-03-19T16:44:57.665Z] 16:44:57 INFO - Buffered messages logged at 16:43:27
[task 2019-03-19T16:44:57.665Z] 16:44:57 INFO - Entering test bound
[task 2019-03-19T16:44:57.665Z] 16:44:57 INFO - Adding a new tab with URL: http://test1.example.org/browser/devtools/client/storage/test/storage-listings.html
[task 2019-03-19T16:44:57.666Z] 16:44:57 INFO - Tab added and finished loading
[task 2019-03-19T16:44:57.667Z] 16:44:57 INFO - Buffered messages logged at 16:43:28
[task 2019-03-19T16:44:57.667Z] 16:44:57 INFO - Found a window: complete
[task 2019-03-19T16:44:57.667Z] 16:44:57 INFO - Buffered messages finished

Flags: needinfo?(dwalsh)
Flags: needinfo?(dwalsh)
Assignee: dwalsh → mratcliffe
Status: NEW → ASSIGNED
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8918328d3461
Allow deletion of storage items via keyboard r=davidwalsh
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I think that's worth being mentioned in https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector.

Sebastian

Keywords: dev-doc-needed

Documentation for this is tracked in: Storage inspector docs tasks for Firefox 68

This was added to the Storage inspector page:

In Firefox 68 and later, you can also delete local and session storage entries by selecting the item and pressing the backspace key.

And this to the release notes:
You can delete local and session storage entries by selecting the item in the storage inspector and pressing the backspace key (bug 1522893).

You need to log in before you can comment on or make changes to this bug.