1593552 - Storage inspector fails to remove cookies after opening context menu

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Oriol Brufau [:Oriol]]

1. Load https://www.google.com
2. Open storage inspector, you should see some cookies
3. RIght-click the 1st one
4. Close the context menu
5. Select the 2nd cookie
6. Press delete key

Expected: the 2nd cookie is removed
Actual: the 1st cookie is removed

7. Select some cookie
8. Press delete key

Expected: the selected cookie is removed
Actual: no cookie is removed. TypeError: data is undefined at https://searchfox.org/mozilla-central/rev/35873cfc312a6285f54aa5e4ec2d4ab911157522/devtools/client/storage/ui.js#1495

Reason: when the context menu opens, it sets contextMenuRowId. This is never cleared. When pressing delete, if contextMenuRowId is set, it tries to remove that entry instead of the selected one. This is wrong, contextMenuRowId should only be used when removing via the context menu, otherwise it should remove the selected one.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:miker, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1593552 - Fix delete key not being able to remove cookies in Storage Inspector after opening context menu. r?miker

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

@Oriol Would you like me to land this for you or do you have permission to land things yourself?

Comment 4

[Oriol Brufau [:Oriol]]

I only have commit access level 1 so I used to add checkin-needed, but now it seems it's just for Thunderbird?
So please land it for me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebfe42cdd589
Fix delete key not being able to remove cookies in Storage Inspector after opening context menu. r=miker

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ebfe42cdd589