1522918 - Optional extension permissions not removed on uninstall

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P3)

Description

[Rob Wu [:robwu]]

When an extension is uninstalled, optional permissions should be removed. This is not the case.

STR:

1. Load the extension from bug 1493396. It will open a sidebar with several buttons.

2. Visit about:config and set extensions.webextOptionalPermissionPrompts to false (this is to work around bug 1493396).

3. Click on the "permissions.contains" button, and confirm that the output is false.

4. Click on the "permissions.request" button, and confirm that the output is true.

5. Click on the "permissions.contains" button, and confirm that the output is true.

6. Visit about:addons, click on "Remove" to disable the extension (this marks the add-on for removal but doesn't remove the data yet because of the undo option).

7. Click on Undo to re-install the addon (thus opening the sidebar again).

8. Click on the "permissions.contains" button, and confirm that the output is true.

9. Visit about:addons, click on "Remove" and refresh the about:addons page to force the uninstall and data removal to happen.

10. Look at the Firefox profile directory, in a file called extension-preferences.json.

Expected:

• At step 9, the file should not contain the ID of the test extension.

Actual:

• At step 9, the file still contains the ID of the test extension.

More information:

• It seems that this code is supposedly responsible for clearing optional permisisons upon uninstallation: https://searchfox.org/mozilla-central/rev/465dbfe030dfec7756b9b523029e90d48dd5ecce/toolkit/components/extensions/parent/ext-permissions.js#102-105
• However, extensions.on("uninstall", extension => { could never have worked, because the signature for the method is (type, ...args), not (...args) - see e.g. https://searchfox.org/mozilla-central/search?q=extensions.on(%22 for examples, and for documentation, see https://searchfox.org/mozilla-central/rev/c035ee7d3a5cd6913e7143e1bce549ffb4a566ff/toolkit/components/extensions/ExtensionCommon.jsm#237-238 (extensions is a SchemaAPIManager and defined here: https://searchfox.org/mozilla-central/rev/c035ee7d3a5cd6913e7143e1bce549ffb4a566ff/toolkit/components/extensions/ExtensionCommon.jsm#1630 )

Comment 1

[Rob Wu [:robwu]]

The original code was introduced in bug 1197420; linking bug for visibility.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

There is a fix for this issue in Shane's patches from Bug 1511636.

In particular, as part of D14800, the call to ExtensionPermission.removeAll is going to be moved into Extension.jsm's UninstallObserver (and a new xpcshell test named test_ext_permissions_uninstall.js is being added).

Comment 3

[Rob Wu [:robwu]]

Bug 1511636 seems to indeed fix this issue. I will mark that as a dependency, and once the other bug is fixed, verify that this bug is fixed too.

Comment 4

[Rob Wu [:robwu]]

I updated the reproduction steps in comment #0. The about:addons page had to be refeshed in order to commit the uninstallation.

Bug 1511636 has improved the result. Previously the permissions were kept even after uninstallation.
Now the permissions are cleared, but the extension ID is still there.

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 1522918 - Fully remove optional permission data upon uninstall

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5542b48b6dfe
Fully remove optional permission data upon uninstall r=rpl

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5542b48b6dfe

Comment 8

[CosminB]

Attachment: Bug1522918.png

I was able to reproduce the issue on Firefox 66.0b7 (20190211185957) under Win 7 64-bit and Mac OS X 10.14.1.

This issue is verified as fixed on Firefox 67.0a1 (20190219094627) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.