1511636 - enable toggling private browsing in about:addons

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Bug 1457001 has a lot of conversation going on, this bug is for the actual work effort.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1511636 toggle private browsing via about:addons

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9029151 [details]
Bug 1511636 toggle private browsing via about:addons

This is a very rough draft/wip patch where I'm trying to hookup a value from about:addons into the Extension class.  There are a few area's in XPI stuff I'm not super familiar with, some input would be appreciated.

Comment 3

[Shane Caraveo (:mixedpuppy)]

We'll change the text to "Private Browsing  On Off".  Need text for the description line underneath.  That text will be sized/colored as the second line under prefs (see general->performance).

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1511636: update incognito support to use pref and permissions

aswan for startupData changes.  rpl for everything.

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 9029151 [details]
Bug 1511636 toggle private browsing via about:addons

Switching f? to ni? so I don't lose track of this

Comment 7

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1511636 update ExtensionPermissions to take id instead of extension instance, r?aswan

Comment 8

[Shane Caraveo (:mixedpuppy)]

Mark, who do you ping for support urls?  i.e. Learn More links in preferences.

Comment 9

[Shane Caraveo (:mixedpuppy)]

Attachment: Screen Shot 2018-12-27 at 12.12.29 PM.png

Banner is being worked on in bug 1516548.  This is a request for alpha on the disabled tag.  I used rgba(128,0,215,.5) for disabled state, rgb(128,0,215) for enabled state.

Comment 11

[Meridel [:meridel]]

@Shane, (In reply to Shane Caraveo (:mixedpuppy) from comment #8)
> Mark, who do you ping for support urls?  i.e. Learn More links in
> preferences.


We can get the URL from Joni, I believe.

Comment 12

[Joni Chan]

> We can get the URL from Joni, I believe.

Yes, here's a link you can use: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/extensions-pb

It will automatically direct to a SUMO article (no content yet).

Comment 13

[emanuela [ux]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)

Created attachment 9033423 [details]
Screen Shot 2018-12-27 at 12.12.29 PM.png

Banner is being worked on in bug 1516548. This is a request for alpha on
the disabled tag. I used rgba(128,0,215,.5) for disabled state,
rgb(128,0,215) for enabled state.

Almost there!

We need to move the tag below the description. Be sure to keep the text all caps.

Regarding the color, it's rgba(98, 0, 164, 1) for the enabled state and rgba(98, 0, 164, 0.4) for the disabled one.

Comment 14

[Shane Caraveo (:mixedpuppy)]

Attachment: extensions list view

Comment 15

[Shane Caraveo (:mixedpuppy)]

Attachment: details view

Comment 16

[Shane Caraveo (:mixedpuppy)]

hrm, I think a change I did in reaction to review feedback resulted in the text getting larger on the details view. will fix.

Comment 17

[Shane Caraveo (:mixedpuppy)]

Attachment: details view

There, that's better.

The primary descriptions here are 1.36em (on osx). I've made the second line 1.1rem

Comment 18

[emanuela [ux]]

Comment on attachment 9035923 [details]
extensions list view

The label is perfect, thank you!

Extensions icons and the buttons need to maintain the same positions they have when the label is not present.

Comment 19

[emanuela [ux]]

Comment on attachment 9035937 [details]
details view

Closer!

I have some notes.

1. The color of the description seems very light for such a small font-size. I will suggest using ##4a4a4f (grey-60)

2. The color of the link seems off. I suggest #0060df (aka blue-60) and to make the link underline. If other links are present on the page, we should make all the links looks like this.

3. Can I see a screen with a full card? I need to understand if there is enough space around the description.

Comment 20

[Shane Caraveo (:mixedpuppy)]

Attachment: full card

I had to use a test extension to get a full card screenshot, let me know if this gives enough visual info for you.

Comment 21

[Shane Caraveo (:mixedpuppy)]

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #19)

1. The color of the description seems very light for such a small font-size. I will suggest using ##4a4a4f (grey-60)

2. The color of the link seems off. I suggest #0060df (aka blue-60) and to make the link underline. If other links are present on the page, we should make all the links looks like this.

The sub-description is new, so changes there would not affect anything else. However, the link color, underline, etc. would either globally affect about:addons, or make this link different than other locations we have "learn more". I think the style is also shared with other links (e.g. author, homepage) as they appear the same, but I haven't verified. Hovering over these links darkens and underlines them.

If we want to make global changes, I'd prefer to have that as a separate bug so I don't have to examine every possibility

Comment 22

[Shane Caraveo (:mixedpuppy)]

2. The color of the link seems off. I suggest #0060df (aka blue-60)

All links in about:addons are defined as var(--in-content-link-color) in css, which is 0a8dff. On hover it changes to #0060df.

Comment 23

[emanuela [ux]]

the link color, underline, etc. would either globally affect about:addons, or make this link different than other locations we have "learn more". I think the style is also shared with other links (e.g. author, homepage) as they appear the same, but I haven't verified. Hovering over these links darkens and underlines them.

If we want to make global changes, I'd prefer to have that as a separate bug so I don't have to examine every possibility

Agree. Let's track it in a separate bug, which should not block this one.

Comment 24

[Shane Caraveo (:mixedpuppy)]

Attachment: extensions list view

Comment 25

[Shane Caraveo (:mixedpuppy)]

Attachment: full details card

Comment 26

[emanuela [ux]]

Comment on attachment 9035984 [details]
extensions list view

Looks good to me.

Comment 27

[emanuela [ux]]

Comment on attachment 9035985 [details]
full details card

Nice! The contrast is way better now. Thank you

Comment 28

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bffd3735a26d83ed8be643c5e59a2a5bbe8cda51

Comment 29

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66fdb34d92c8219e2defd80ba10cd07b4444f99f

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26ac80bf3391
update ExtensionPermissions to take id instead of extension instance, r=aswan,rpl
https://hg.mozilla.org/integration/autoland/rev/9553d0cc4eea
update incognito support to use pref and permissions r=rpl,aswan,kmag
https://hg.mozilla.org/integration/autoland/rev/ba4db0fbeb24
toggle private browsing via about:addons r=rpl,mstriemer,flod,kmag

Comment 31

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/26ac80bf3391
https://hg.mozilla.org/mozilla-central/rev/9553d0cc4eea
https://hg.mozilla.org/mozilla-central/rev/ba4db0fbeb24

Comment 32

[CosminB]

Attachment: Bug1511636.png

This issue is verified as fixed on Firefox 67.0a1 (20190130001444) under Win 7 64-bit and Mac OS X 10.14.1.

The preference ‘extensions.allowPrivateBrowsingByDefault’ is set to true by default.

When the preference is set to true, the extensions are enabled by default in private windows.
When the preference is set to false, the extensions are not enabled by default in private windows.

Please see the attached screenshot.

Comment 34

[Irene Smith]

I added a note to the incognito page:

Note: Firefox 67 also adds a new setting in about:config, extensions.allowPrivateBrowsingByDefault, which defaults to false. This means that the default for a newly installed extension would be "not_allowed" meaning that the extension would not be able to run in a private window or tab. See this support article: Extensions in Private Browsing for details from the user's perspective.

I will also add the incognito manifest key to the 67 release notes.

Comment 35

[Shane Caraveo (:mixedpuppy)]

(In reply to Irene Smith from comment #34)

I added a note to the incognito page:

Note: Firefox 67 also adds a new setting in about:config, extensions.allowPrivateBrowsingByDefault, which defaults to false. This means that the default for a newly installed extension would be "not_allowed" meaning that the extension would not be able to run in a private window or tab. See this support article: Extensions in Private Browsing for details from the user's perspective.

I will also add the incognito manifest key to the 67 release notes.

I don't think we should be documenting preferences that are not visible to the use in about:preferences. This preference was there to be able to turn the feature on or off at an appropriate time, users should not touch it. It will be removed after a version or two.

Comment 36

[Irene Smith]

Made the requested changes to the page and to the release notes.