1523118 - atk: Implement scrollsubstringto ATK API

Status: RESOLVED FIXED

(Firefox :: Disability Access, enhancement)

Description

[Samuel Thibault]

Hello,

For proper following of speech synthesis, we have added to ATK a ScrollSubstringTo interface, just like IA2's interface. I will attach a patch to add support in Firefox. This is very much like the addition of the scrollto interface on https://bugzilla.mozilla.org/show_bug.cgi?id=1458548

Samuel

Comment 1

[Samuel Thibault]

Attachment: patch

Comment 2

[Samuel Thibault]

(this was tested on https://treeherder.mozilla.org/#/jobs?repo=try&revision=0751f241da9040a3bfb25820e5b7bd881c759417 )

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 9039358 [details] [diff] [review]
patch

Review of attachment 9039358 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/nsMaiInterfaceText.cpp
@@ +590,5 @@
>  
>    return FALSE;
>  }
> +
> +static gboolean scrollSubstringToCB(AtkText *aText,

nit: AtkText* aText, here and below

Comment 4

[Samuel Thibault]

Attachment: patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80254b1b3aa1
atk: Implement scrollsubstringto ATK API. r=surkov

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/80254b1b3aa1