Closed Bug 1523118 Opened 9 months ago Closed 9 months ago

atk: Implement scrollsubstringto ATK API

Categories

(Firefox :: Disability Access, enhancement)

All
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: samuel.thibault, Assigned: samuel.thibault)

Details

Attachments

(1 file, 1 obsolete file)

Hello,

For proper following of speech synthesis, we have added to ATK a ScrollSubstringTo interface, just like IA2's interface. I will attach a patch to add support in Firefox. This is very much like the addition of the scrollto interface on https://bugzilla.mozilla.org/show_bug.cgi?id=1458548

Samuel

Attached patch patch (obsolete) — Splinter Review
Attachment #9039358 - Flags: review?(surkov.alexander)
Assignee: nobody → samuel.thibault
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 9039358 [details] [diff] [review]
patch

Review of attachment 9039358 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/nsMaiInterfaceText.cpp
@@ +590,5 @@
>  
>    return FALSE;
>  }
> +
> +static gboolean scrollSubstringToCB(AtkText *aText,

nit: AtkText* aText, here and below
Attachment #9039358 - Flags: review?(surkov.alexander) → review+
Attached patch patchSplinter Review
Attachment #9039358 - Attachment is obsolete: true
Keywords: checkin-needed

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80254b1b3aa1
atk: Implement scrollsubstringto ATK API. r=surkov

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.