1523140 - Derive more and shrink repr(c) representation of MaxLength / MozLength.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1523140 - Derive more length stuff, and shrink MaxLength / MozLength's repr(C) representation.

This patch:

• Makes LengthPercentageOrAuto generic, and removes a bunch of code fo
  LengthPercentageOrNone, which was used only for servo and now can use the
  normal MaxLength (with a cfg() guard for the ExtremumLength variant).

• Shrinks MaxLength / MozLength's repr(C) reperesentation by reducing enum
  nesting. The shrinking is in preparation for using them from C++ too, though
  that'd be a different bug.

• Moves NonNegative usage to the proper places so that stuff for them can be
  derived.

I did this on top of bug 1523071 to prove both that it could be possible and
that stuff wasn't too messy. It got a bit messy, but just because of a bug I
had fixed in bindgen long time ago already, so this updates bindgen's patch
version to grab a fix instead of ugly workarounds :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b396fba7eae89ac5dfa8efe46aea5dbf39629901

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a801f6c5c8f
Derive more length stuff, and shrink MaxLength / MozLength's repr(C) representation. r=boris

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5a801f6c5c8f