1523144 - Fixup MIDL setup after bug 1516090

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1523144 - Don't pass compiler flags down to MIDL.

This turns out to not work at all, because this prevents MIDL itself to
pass -I to the compiler, which then proceeds to fail. We're just lucky
that our MSVC detection doesn't yield any default flags so this is
effectively dead code.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1523144 - Search for MSVC for MIDL in more locations.

In some setups, MSVC is not found through vc_compiler_path, so we may
need a more complete path. toolchain_search_path contains
vc_compiler_path, as well as $PATH (among others), increasing our
chances.

Also, if we fail to find cl.exe that way, fail early, instead of failing
while processing config.status, failing to serialize MIDL_FLAGS because
it contains a None.

Depends on D17767

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e3c47c212f
Don't pass compiler flags down to MIDL. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/8d0ab7804a7c
Search for MSVC for MIDL in more locations. r=froydnj

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e3e3c47c212f
https://hg.mozilla.org/mozilla-central/rev/8d0ab7804a7c