Closed Bug 1523145 Opened 10 months ago Closed 10 months ago

Remove mk_export_correct_style

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.

It turns out, we don't need to mk_add_options export the variables
from the in-tree mozconfigs. If anything, that causes problems when
trying to simplify the mozconfigs, because it makes the variables
exported from .mozconfig.mk, overriding what configure may change and
store in autoconf.mk.

All the variables are handled by configure in a way that makes them
available in autoconf.mk, so there's no loss there, and with the
python/shell-based mozconfig loader, it turns out we don't need to go
through extra normalization via cmd.

autospider.py, being its own pseudo-mozconfig parser, still does need
it, though, but it was hooking into it already, so just inline that.

Depends on: 1523153
Blocks: 1523201
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/53ea75c61113
Remove mk_export_correct_style. r=froydnj
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d9424aeb558e
Port bug 1523145 - Remove mk_export_correct_style from C-C's mozconfigs. rs=bustage-fix DONTBUILD
Depends on: 1524059
You need to log in before you can comment on or make changes to this bug.