1523198 - Make DIA_SDK_PATH and VC_PATH normal configure inputs

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1523198 - Make DIA_SDK_PATH a normal configure input.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1523198 - Refactor vc_compiler_path.

• Only expose it as well as --with-visual-studio-version when the host
  system is Windows.
• Don't run vswhere twice (once for host and once for target).

Depends on D17785

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1523198 - Make VC_PATH a normal configure input.

And use it as an alternative to vswhere, instead of the current late
check. This allows to use VC_PATH when using a MSVC archive that is not
installed through the VS installer, and not have to care about PATH.

Depends on D17786

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33574651b2f9
Make DIA_SDK_PATH a normal configure input. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/1003c71f584f
Refactor vc_compiler_path. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/4c51aefda722
Make VC_PATH a normal configure input. r=froydnj

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/33574651b2f9
https://hg.mozilla.org/mozilla-central/rev/1003c71f584f
https://hg.mozilla.org/mozilla-central/rev/4c51aefda722