1523282 - mark restyle-inside-first-line.html random because of inconsistency

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: disabled_restyle-inside-first-line.html.diff

If one changes refreshdriver ticking at all during page load,
restyle-inside-first-line.html starts to fail.
And locally that test fails even without any changes, as bug 1523134 shows.

(Some random issue in styling/layout/painting shouldn't block page load optimization work)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9039512 [details] [diff] [review]
disabled_restyle-inside-first-line.html.diff

Review of attachment 9039512 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/first-line/reftest.list
@@ +32,5 @@
>  == 469227-2.html 469227-2-ref.html
>  == 469227-3.html 469227-3-ref.html
>  
> +# disabled because of bug 1523134
> +# == restyle-inside-first-line.html restyle-inside-first-line-ref.html

Can you annotate it with random or fails instead of commenting it out?

So either:

fails == restyle-inside-first-line.html restyle-inside-first-line-ref.html # bug 1523134

Or:

random == restyle-inside-first-line.html restyle-inside-first-line-ref.html # bug 1523134

Fails would let us know when it's fixed.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

It doesn't fail all the time. I can use random

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: random_restyle-inside-first-line.html.diff

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09c820c1e092
mark restyle-inside-first-line.html random because of inconsistency (bug  1523134), r=emilio

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/09c820c1e092