1523412 - GetStreamCaps can fail with S_FALSE

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Comment 1

[Nils Ohlmeier [:drno]]

https://msdn.microsoft.com/en-us/windows/desktop/dd319787 explains that GetStreamCaps() can return S_FALSE, which is not caught by FAILED().

Comment 2

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9f16a61ed2897d304cacf3bc5c55b6015623e3c

Comment 3

[Nils Ohlmeier [:drno]]

Attachment: Bug 1523412: compare GetStreamCaps return values against S_OK. r?dminor

Comment 4

[Nils Ohlmeier [:drno]]

After merging we should also upstream this (as the latest Chromium code still has the same bug - even though the non-webrtc parts of Chromiums code check GetStreamCaps() return value properly - even with comments describing the problem here).

Comment 6

[Nils Ohlmeier [:drno]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09aa1bb85ae7b93c262edcc450c0e2064defa6ae

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf6287bb0477
compare GetStreamCaps return values against S_OK. r=dminor

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/cf6287bb0477

Comment 9

[Dan Minor [:dminor]]

Filed https://bugs.chromium.org/p/webrtc/issues/detail?id=10267 to track this upstream.

Comment 10

[Dan Minor [:dminor]]

Upstream review: https://webrtc-review.googlesource.com/c/src/+/120644

Comment 11

[Dan Minor [:dminor]]

Upstream fix: https://webrtc.googlesource.com/src.git/+/e22498cc3e0618f83bbe0e169507ad51b1769b2b