Open Bug 1523439 Opened 11 months ago Updated 9 months ago

Audit usage of nsLayoutUtils::IsAncestorFrameCrossDoc

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

REOPENED

People

(Reporter: emilio, Assigned: jwatt)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Replacing for IsProperAncestorFrame if needed.

Depends on: 1523500
Summary: Audit usage of nsLayoutUtils::IsCrossDocAncestorFrame → Audit usage of nsLayoutUtils::IsAncestorFrameCrossDoc
Priority: -- → P3

I didn't see any consumers of this function that we need to worry about. Things like event targeting and display list pruning for pages are not something we need to worry about across iframe process boundaries.

Assignee: nobody → jwatt
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED

Oops, I misread the function name in the title.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I cleaned up my own notes that I had on the consumers of this method:

nsDisplayPerspective::CreateWebRenderCommands:

mattwoodrow says this should not be using the cross-document variant
of this function. I think we could fix this as part of bug 1523500
(I mentioned it over there in bug 1523500 comment 5).

nsIPresShell::ClearMouseCapture:

Covered by bug 1533499.

nsRootPresContext::ComputePluginGeometryUpdates:

Covered by bug 1525720?

GetClosest in PositionedEventTarget.cpp:

Henri/Botond are working on making sure that events go to the correct process
using the APZ code, so this reaching across document boundaries should be
okay at that point.

DOMIntersectionObserver::Update:

This is fine. Script can't observe elements that it can't reach (i.e. anything
cross-document would need to belong to the same origin etc.). The exception to
that is when script passes 'null' to observe intersection with the root
viewport.

nsLayoutUtils::IsProperAncestorFrameCrossDoc

No issues - see comment 1.

Depends on: 1533499, 1518911
You need to log in before you can comment on or make changes to this bug.