Closed Bug 1523542 Opened 5 years ago Closed 5 years ago

Change .key IDs to .accesskey IDs in addons.properties

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 67.0

People

(Reporter: Tonnes, Assigned: nONoNonO)

References

Details

Attachments

(1 file)

In addons.properties, a few access keys appear to have .key IDs. As a result, they may show up in Transvision’s Keyboard Shortcuts check due to not being identical to en-US.

addonPostInstall.okay.label=OK
addonPostInstall.okay.key=O

addonPostInstall.restart.label=Restart now
addonPostInstall.restart.key=R
addonPostInstall.noRestart.label=Not now
addonPostInstall.noRestart.key=N

I assume they should be changed to .accesskey IDs.

Assignee: nobody → o.e.ekker
Attachment #9040969 - Flags: review?(mkmelin+mozilla)
Depends on: 1496632, 1498967
Comment on attachment 9040969 [details] [diff] [review]
Patch to change keys to accesskeys

Review of attachment 9040969 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin
Attachment #9040969 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e06a970817c6
Change .key IDs to .accesskey IDs in addons.properties. r=mkmelin

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 67.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: