1523632 - Add-on card in about:addons is broken with longer translation

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: immagine.png

The label is cut, which is kind of expected. I wasn't expecting the button to fall out of the card though.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #0)

The label is cut, which is kind of expected.

To be clear, we really shouldn't cut this either.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1523632 - Part 1: Wrap the extension private browsing label on details page r?mixedpuppy,flod

Comment 3

[Mark Striemer [:mstriemer]]

So on Beta the details card is fine, it expands in width a little to fit the automatic updates row. On Nightly, once it expands it gets scrollbars instead and the content is "hidden".

This is because the error/warning containers now have a max-width and that becomes where the scrollbar goes, instead of at the full width of (the rest of) the pane.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1523632 - Part 2: Allow detail cards to expand without scrollbars r?mixedpuppy

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea5bca13b8d2
Part 1: Wrap the extension private browsing label on details page r=mixedpuppy,flod
https://hg.mozilla.org/integration/autoland/rev/c19692b8561d
Part 2: Allow detail cards to expand without scrollbars r=mixedpuppy

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ea5bca13b8d2
https://hg.mozilla.org/mozilla-central/rev/c19692b8561d

Comment 7

[CosminB]

Attachment: Bug1523632-IT.png

I can reproduce this issue on Firefox 67.0a1 - it (20190129103321) under Win 7 64-bit.

This issue is verified as fixed on Firefox 67.0a1 - it (20190130094929) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Comment 8

[CosminB]

Attachment: Bug1523632-RU.png

I also noticed that for Japanese and Russian builds (probably for more builds), the “Run in Private Windows” is not translated.

Is this expected Mark?

Comment 9

[Francesco Lodolo [:flod]]

(In reply to CosminB from comment #8)

Created attachment 9040111 [details]
Bug1523632-RU.png

I also noticed that for Japanese and Russian builds (probably for more builds), the “Run in Private Windows” is not translated.

It is (Nightly is localized only by a handful of locales)