Closed Bug 1523734 Opened 8 months ago Closed 6 months ago

Migrate about:blocked's DTD (phishing-afterload-warning-message.dtd ) to fluent

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: nautilus, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There are 2 strings used in browser-menubar.inc :

safeb.palm.notdeceptive.label
safeb.palm.notdeceptive.accesskey

These can be moved to report-phishing.dtd .

Any other strings should only be referenced from blockedSite.xhtml, but please check. After this conversion, there should be no more dtd usage left for blockedSite.xhtml ( about:blocked ).

Assignee: nobody → freychr3
Status: NEW → ASSIGNED

(In reply to :Gijs (he/him) from comment #0)

There are 2 strings used in browser-menubar.inc :

safeb.palm.notdeceptive.label
safeb.palm.notdeceptive.accesskey

These can be moved to report-phishing.dtd .

I don't think there's value in moving around DTD strigns. They will show up as new, and will need to be retranslated in ~100 languages.

Instead of completely removing the old file, we can just leave the 2 strings there, and they will be removed when we can (i.e. we convert browser-menubar.inc).

(In reply to Francesco Lodolo [:flod] from comment #2)

(In reply to :Gijs (he/him) from comment #0)

There are 2 strings used in browser-menubar.inc :

safeb.palm.notdeceptive.label
safeb.palm.notdeceptive.accesskey

These can be moved to report-phishing.dtd .

I don't think there's value in moving around DTD strigns. They will show up as new, and will need to be retranslated in ~100 languages.

Instead of completely removing the old file, we can just leave the 2 strings there, and they will be removed when we can (i.e. we convert browser-menubar.inc).

On the other hand, as it is, we're paying a performance penalty for having to read an additional DTD for just these 2 strings when opening browser.xul (if/when there's no startupcache), even though these strings are almost never visible. :-(

(In reply to :Gijs (he/him) from comment #3)

(In reply to Francesco Lodolo [:flod] from comment #2)

(In reply to :Gijs (he/him) from comment #0)

There are 2 strings used in browser-menubar.inc :

safeb.palm.notdeceptive.label
safeb.palm.notdeceptive.accesskey

These can be moved to report-phishing.dtd .

I don't think there's value in moving around DTD strigns. They will show up as new, and will need to be retranslated in ~100 languages.

Instead of completely removing the old file, we can just leave the 2 strings there, and they will be removed when we can (i.e. we convert browser-menubar.inc).

On the other hand, as it is, we're paying a performance penalty for having to read an additional DTD for just these 2 strings when opening browser.xul (if/when there's no startupcache), even though these strings are almost never visible. :-(

In fact, that gives me an idea. We can move these strings to the new FTL already and insert the FTL dynamically into browser.xul when we'd actually use these strings, at https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/browser/base/content/browser-safebrowsing.js#24 if and only if isPhishingPage is true.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d0c230559312
Migrate about:blocked to Fluent r=flod,Gijs
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.