Closed Bug 1594025 Opened 5 months ago Closed 5 months ago

"This isn't a deceptive site..." hamburger menu item is unreadable

Categories

(Firefox :: Menus, defect)

71 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- verified

People

(Reporter: zstimi, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image DeceptiveSite.png

Affected versions

  • Firefox 71.0b7
  • Firefox 72.0a1
  • Firefox 70.0.1
  • Firefox 69.0
  • Firefox 68.2.0esr

Affected platforms

  • Windows 10 x64
  • Windows 8.1 x64
  • macOS 10.15
  • Ubuntu 18.04 x64

Steps to reproduce

  1. Launch Firefox with new profile.
  2. Access the https://www.itisatrap.org/firefox/its-a-trap.html link.
  3. Open Hamburger menu/Help.

Expected result

  • "This isn't a deceptive site..." menu item is readable.

Actual result

  • "This isn't a deceptive site" menu item is unreadable.

Regression range

Additional notes

  • Please observe the attached screenshot for further information regarding this issue.
Component: Themes → Menus
Product: Toolkit → Firefox
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

The help view copies strings from the main menubar. When we moved the original DTD string
to ftl, there were performance implications for using it in browser.xhtml, so it was
only added once needed. The help view copies attributes from the items in the main menubar's
help menu, and so didn't copy the label for this item, resulting in the broken
behaviour.

To fix this, it's enough to have the string in the markup. As we've moved the other strings
into menubar.ftl, I'm taking the opportunity to move this string there, too, next to its
sibling string to report deceptive sites.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/489afa3eb121
move 'this site is not deceptive' string into markup to allow help hamburger menu to copy it, r=flod,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

I can confirm this issue is fixed, I verified using Firefox 72.0a1 on Win 10 x64, macOS 10.15 and Ubuntu 18.04 x64.

Has Regression Range: --- → yes
Has STR: --- → yes
You need to log in before you can comment on or make changes to this bug.