Closed Bug 1523736 Opened 2 years ago Closed 3 months ago

Migrate updates.dtd to fluent

Categories

(Toolkit :: Application Update, task, P3)

task

Tracking

()

VERIFIED FIXED
mozilla77
Tracking Status
firefox67 --- wontfix
firefox77 --- verified

People

(Reporter: Gijs, Assigned: yanbingj, Mentored)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd

This is only used from https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/content/updates.xul . We will need to keep the doctype declaration there purely for the macOS ifdef.

As with other dialogs, we'll probably need to make sure it sizes to the content after the localization is complete.

Just heads up that this UI might be going away according to :rstrong in bug 1515484.

Priority: -- → P3
Blocks: 1608163
No longer blocks: 1517304
Type: enhancement → task
Blocks: 1581212

It doesn't look like bug 1521632 is assigned or prioritized above P3, so I think this one is safe to do - it's unlikely that updateElevation.xhtml is going to get removed out from under us. Plus, it's likely that the doorhanger proposed in bug 1521632 would want to use some or all of these strings anyways, so might as well get them converted.

Assignee: nobody → yanbingj

Hey Kevin,

To test this, drop this into the Browser Console to bring up the dialog:

Services.ww.openWindow(null, "chrome://mozapps/content/update/updateElevation.xhtml", "Update:Elevation", "chrome,centerscreen,resizable=no,titlebar,toolbar=no,dialog=no", null);
Status: NEW → ASSIGNED
Attachment #9136341 - Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/afe014a1b475
migrate updates.dtd to fluent r=fluent-reviewers,flod,Gijs

Backed out changeset afe014a1b475 (bug 1523736) for causing build bustages

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298115854&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=afe014a1b4753a28a64591a85dca7eec6f559f14

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298115874&repo=autoland&lineNumber=1484

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298115854&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=76c698c7109d0672f3f1d9b25cd26edb3e59d812

task 2020-04-17T16:11:50.989Z] 16:11:50     INFO -  js/src> Creating config.status
[task 2020-04-17T16:11:51.032Z] 16:11:51     INFO -  Creating config.status
[task 2020-04-17T16:11:51.316Z] 16:11:51     INFO -  Reticulating splines...
[task 2020-04-17T16:11:53.044Z] 16:11:53     INFO -   0:01.76 File already read. Skipping: /builds/worker/checkouts/gecko/gfx/angle/targets/angle_common/moz.build
[task 2020-04-17T16:12:07.316Z] 16:12:07    ERROR -  Traceback (most recent call last):
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 181, in <module>
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      sys.exit(main(sys.argv))
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 57, in main
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      return config_status(config)
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 176, in config_status
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      return config_status(args=[], **normalize(sanitized_config))
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 148, in config_status
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      the_backend.consume(definitions)
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/backend/base.py", line 129, in consume
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      if (not self.consume_object(obj) and
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/backend/fastermake.py", line 65, in consume_object
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      self._consume_jar_manifest(obj)
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/backend/common.py", line 508, in _consume_jar_manifest
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -      '%s: Cannot find %s (tried %s)' % (obj.path, e.source, src.full_path))
[task 2020-04-17T16:12:07.317Z] 16:12:07     INFO -  Exception: jar.mn: Cannot find chrome/mozapps/update/updates.dtd (tried /builds/worker/checkouts/gecko/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd)
[task 2020-04-17T16:12:08.321Z] 16:12:08     INFO -  *** Fix above errors and then restart with\
[task 2020-04-17T16:12:08.321Z] 16:12:08     INFO -                 "./mach build"
[task 2020-04-17T16:12:08.321Z] 16:12:08     INFO -  client.mk:111: recipe for target 'configure' failed
[task 2020-04-17T16:12:08.322Z] 16:12:08     INFO -  make: *** [configure] Error 1
[task 2020-04-17T16:12:08.391Z] 16:12:08    ERROR - Return code: 2
[task 2020-04-17T16:12:08.391Z] 16:12:08  WARNING - setting return code to 2
[task 2020-04-17T16:12:08.391Z] 16:12:08    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2020-04-17T16:12:08.391Z] 16:12:08    FATAL - Running post_fatal callback...
[task 2020-04-17T16:12:08.391Z] 16:12:08    FATAL - Exiting -1
[task 2020-04-17T16:12:08.392Z] 16:12:08     INFO - [mozharness: 2020-04-17 16:12:08.391997Z] Finished build step (failed)
[task 2020-04-17T16:12:08.392Z] 16:12:08     INFO - Running post-run listener: _parse_build_tests_ccov
[task 2020-04-17T16:12:08.392Z] 16:12:08     INFO - Running command: ['/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python', 'mach', 'python', 'testing/parse_build_tests_ccov.py'] in /builds/worker/checkouts/gecko
[task 2020-04-17T16:12:08.392Z] 16:12:08     INFO - Copy/paste: /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python mach python testing/parse_build_tests_ccov.py
[task 2020-04-17T16:12:08.394Z] 16:12:08     INFO - Using env: {'ACCEPTED_MAR_CHANNEL_IDS': 'firefox-mozilla-central',
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f84f2ac3b1f7
migrate updates.dtd to fluent r=fluent-reviewers,flod,Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.