1523830 - Popup windows are not being allowed from about:newtab in FF65 when running Bookmarklets

Status: RESOLVED DUPLICATE of bug 1524137

(Core :: DOM: Core & HTML, defect, P2)

Description

[adam]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Attempting to run a bookmarklet from about:newtab or any tab rather, the new windows are blocked.

See the bookmarklet below that will open multiple sites at once.

javascript:(function(){window.open('https://www.cnn.com','_blank');window.open('https://www.msnbc.com','_blank');window.open('https://www.huffingtonpost.com','_blank');window.open('https://www.foxnews.com','_blank');window.open('https://www.apnews.com','_blank');window.open('https://www.bbc.com','_blank');})()

Actual results:

FF displays a "popup blocked" notification bar, and Allow is chosen. I added the about:newtab and about:home to the allowed domains for pop-up and the issue continues to persist.

Expected results:

The windows should all open new tabs regardless of what web page is viewed.

Comment 1

[Matthias Versen [:Matti]]

pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6e842238034cd847ede178b4e65ea07704e4ffe6&tochange=274f95b85267d07ae0d2eceb95c683dda098ce82

2019-01-30T10:57:13: DEBUG : Found commit message:
Bug 675574 - Allow just 1 window.open() per event, r=smaug

2019-01-30T10:57:13: DEBUG : Did not find a branch, checking all integration branches
2019-01-30T10:57:13: INFO : The bisection is done.

This looks like an expected result of bug 675574 but marking NEW for a decision of the developer.

Comment 2

[Andrea Marchesini [:baku]]

FF displays a "popup blocked" notification bar, and Allow is chosen. I added the about:newtab and about:home to the allowed domains for pop-up and the issue continues to persist.

The problem is not in the blocking itself, which is fine. I think the issue is that we don't allow about:newtabs and about:home to open popups also when added to the allow list.

Comment 4

[roadkiller.cl]

(In reply to Andrea Marchesini [:baku] from comment #2)

FF displays a "popup blocked" notification bar, and Allow is chosen. I added the about:newtab and about:home to the allowed domains for pop-up and the issue continues to persist.

The problem is not in the blocking itself, which is fine. I think the issue is that we don't allow about:newtabs and about:home to open popups also when added to the allow list.

Do you mean this will not be fixed to work from any tab without any pop-up blocker exception like before? I was really used to use my bookmarklet anywhere with nothing but the bookmarklet itself. Though, some websites (like Github for example, even before FF65) somehow block the bookmarklet javascript code to run.

Note: I am the author of the duplicate PR, sorry again for the inconvenience.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to roadkiller.cl from comment #4)

(In reply to Andrea Marchesini [:baku] from comment #2)

FF displays a "popup blocked" notification bar, and Allow is chosen. I added the about:newtab and about:home to the allowed domains for pop-up and the issue continues to persist.

The problem is not in the blocking itself, which is fine. I think the issue is that we don't allow about:newtabs and about:home to open popups also when added to the allow list.

Do you mean this will not be fixed to work from any tab without any pop-up blocker exception like before? I was really used to use my bookmarklet anywhere with nothing but the bookmarklet itself. Though, some websites (like Github for example, even before FF65) somehow block the bookmarklet javascript code to run.

Note: I am the author of the duplicate PR, sorry again for the inconvenience.

Hi :baku, second comment 4, so is this bug behaving as expected after bug 675547? Is there anything we'd do for this bug? Thanks!

Comment 6

[ephbase-moz]

https://bugzilla.mozilla.org/show_bug.cgi?id=1524137#c8

Bug 675574, broke Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_POPUP.

AFAICT this flag was specifically intended to allow popups without any revision, for privileged cases that warranted it, such as bookmarklets

The only loads that should have been subjected to popup revision are unprivileged content triggered ones. Bug 675574 failed to do that.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something we might aim to fix in 68? It isn't clear if this might get resolved by bug 1524137, but neither bug has an owner.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #7)

Is this something we might aim to fix in 68? It isn't clear if this might get resolved by bug 1524137, but neither bug has an owner.
I'm taking via email. Will get back here. Thanks Liz for reminder.

Comment 9

[Johann Hofmann [:johannh]]

Let's dupe this to bug 1524137, since that one has some more relevant info.